436800 - setElementValue method needs to deal with preference on a button

Status: RESOLVED INVALID

(Toolkit :: Preferences, defect)

Description

[Ian Neal]

When a boolean preference is assigned to a button then if it is set to true it should disable the button as it did under the way things were done under xpfe preferences.
i.e. <button label="&button.label;"
             preference="pref.browser.disable_button.foobar"/>
e.g. http://lxr.mozilla.org/seamonkey/source/browser/components/preferences/privacy.xul#141
http://lxr.mozilla.org/seamonkey/source/browser/components/preferences/privacy.xul#166

Comment 1

[Ian Neal]

Attachment: Add button as an element that takes preference patch v0.1

This brings back functionality that was present under xpfe preferences and is still trying to be used within Firefox preferences (see above for examples).

Comment 2

[Phil Ringnalda (:philor)]

I had the impression that it was an intentional design decision to only support disable_button when the pref was locked (since it's pretty pointless otherwise). With a locked pref, don't you hit the first two conditions (this.locked and then !this.isElementEditable), and thus correctly set it disabled and return?

Comment 3

[Ian Neal]

As per comment 2