Closed
Bug 436871
Opened 17 years ago
Closed 17 years ago
Tidy up display and message row attributes of messages to another view
Categories
(Other Applications Graveyard :: ChatZilla, defect)
Other Applications Graveyard
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: glenjamin+bmo, Assigned: glenjamin+bmo)
References
Details
(Whiteboard: [cz-0.9.83])
Attachments
(1 file, 1 obsolete file)
|
2.79 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
The nicknames for messages for which the boolean "toOther" is set (in __display()), are not clickable.
Easy fix, patch included.
Attachment #323377 -
Flags: review?(gijskruitbosch+bugs)
|
||
Updated•17 years ago
|
OS: Windows XP → All
Hardware: PC → All
|
Assignee | |
Comment 1•17 years ago
|
||
i've also noticed that messages which are "toOther" still get "ME!" appended to their fromAttr string.
While this is technically correct, its not useful as the source object is not the one being displayed in the nickname column.
I've incorporated a fix for this as well.
Status: NEW → ASSIGNED
Summary: The nickname for a message to another view is not hyperlinked → Tidy up display and message row attributes of messages to another view
|
|
Assignee | |
Comment 2•17 years ago
|
||
Attachment #323377 -
Attachment is obsolete: true
Attachment #323389 -
Flags: review?(gijskruitbosch+bugs)
Attachment #323377 -
Flags: review?(gijskruitbosch+bugs)
|
||
Comment 3•17 years ago
|
||
Comment on attachment 323389 [details] [diff] [review]
fixes "ME!" usage as well
r=me
Attachment #323389 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
||
Updated•17 years ago
|
Assignee: rginda → glenjamin+bmo
Status: ASSIGNED → NEW
|
|
||
Updated•17 years ago
|
Status: NEW → ASSIGNED
|
|
||
Comment 4•17 years ago
|
||
Checking in mozilla/extensions/irc/xul/content/static.js;
/cvsroot/mozilla/extensions/irc/xul/content/static.js,v <-- static.js
new revision: 1.278; previous revision: 1.277
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.83]
|
||
Updated•3 months ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•