436909 - safebrowsing cause 'asynchronous entity' XML error in Hebrew

Status: RESOLVED FIXED

(Mozilla Localizations :: he / Hebrew, defect)

Description

[Tomer Cohen :tomer]

I've found that http://www.mozilla.com/firefox/its-a-trap.html is not accessible for Hebrew users. The problem is with phishing-afterload-warning-message.dtd, and we would like it to get fixed ASAP.

שגיאה בניתוח XML:‏ ישות לא מתואמת (א־סינכרונית) מיקום: jar:file:///home/tomer/firefox3/he/firefox/chrome/browser.jar!/content/browser/safebrowsing/blockedSite.xhtml שורה מספר 201, עמודה 45:          <p id="errorLongDescText_malware">&safeb.blocked.malware.longDesc;</p>
--------------------------------------------^

Comment 1

[Tomer Cohen :tomer]

Attachment: patch

Lack of <p>. 

I guess it won't be possible to commit it before RC2, right?

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 323431 [details] [diff] [review]
patch

</p>\n<p> -> </p><p>, please, too.

Comment 3

[Tomer Cohen :tomer]

Attachment: patch

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 323433 [details] [diff] [review]
patch

r=me, please wait for approval to actually land this patch.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

We'll fix this in 3.0.1 and relnote for now. Pages are still blocked, just with a sucky, sucky UI. Is it phishing only, or phishing and malware which are affected?

Comment 6

[Simon Montagu :smontagu]

(In reply to comment #5)
> We'll fix this in 3.0.1 and relnote for now. Pages are still blocked, just with
> a sucky, sucky UI. Is it phishing only, or phishing and malware which are
> affected?
> 

Both http://www.mozilla.com/firefox/its-a-trap.html and http://www.mozilla.com/firefox/its-an-attack.html show this error in a current he build.

Comment 7

[Tomer Cohen :tomer]

(In reply to comment #6)
> Both http://www.mozilla.com/firefox/its-a-trap.html and
> http://www.mozilla.com/firefox/its-an-attack.html show this error in a current
> he build.
Both seems to work well after appling the patch. 

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 323433 [details] [diff] [review]
patch

a=beltzner, but I can't set the flag. Axel?

Comment 9

[Axel Hecht [:Pike]]

Comment on attachment 323433 [details] [diff] [review]
patch

a=me, please land this with a check-in comment referencing this bug and my approval.

Please use the fixed1.9.0.1 and verified1.9.0.1 keywords to track landing and testing.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Is this FIXED now?

Comment 11

[Yehuda]

(In reply to comment #10)
> Is this FIXED now?
> 

Fixed in Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; he; rv:1.9.0.1pre) Gecko/2008062504 GranParadiso/3.0.1pre

Comment 12

[Tomer Cohen :tomer]

(In reply to comment #11)
> Fixed in Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; he; rv:1.9.0.1pre)
> Gecko/2008062504 GranParadiso/3.0.1pre
(I'll give it a second check this Saturday, Since it is very important to get this bug fixed.)