437078 - GUIDs not included in bookmark backups

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Dietrich Ayala (:dietrich)]

The problem with doing this is that when bookmarks are restored, extensions such as Foxmarks and Weave will have lost unique identity across profiles for bookmark items.

I don't know how either extension handles the situation where you have 2 profiles, that are the same, but appear to have never been synced. It's likely that it is painful regardless.

Comment 1

[Dietrich Ayala (:dietrich)]

Attachment: fix + test

there is no reason that i can discern for that line of code to be present.

Comment 2

[Asaf Romano (gone)]

Comment on attachment 323587 [details] [diff] [review]
fix + test

I'm pretty sure the idea behind this check is similar to the one behind the livemark-annotation check - don't get or set "internal" annotations within front-end code (and rather use the apis which expose these annotations, in this case get/setItemGUID). That said, I don't think it's worth changing the data structure in this case, especially now that this file lives in toolkt/.

So, r=mano.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

If this is ready to go, can we get it marked for approval1.9.0.1?

Comment 4

[Dietrich Ayala (:dietrich)]

changeset:   15657:b96b023e4a43

Comment 5

[Samuel Sidler (old account; do not CC)]

Comment on attachment 323587 [details] [diff] [review]
fix + test

Approved for 1.9.0.2. Please land in CVS. a=ss

Comment 6

[Dietrich Ayala (:dietrich)]

Checking in toolkit/components/places/src/utils.js;
/cvsroot/mozilla/toolkit/components/places/src/utils.js,v  <--  utils.js
new revision: 1.21; previous revision: 1.20
done
RCS file: /cvsroot/mozilla/toolkit/components/places/tests/bookmarks/test_restore_guids.js,v
done
Checking in toolkit/components/places/tests/bookmarks/test_restore_guids.js;
/cvsroot/mozilla/toolkit/components/places/tests/bookmarks/test_restore_guids.js,v  <--  test_restore_guids.js
initial revision: 1.1
done

Comment 7

[Bill Wood]

Please see bug 457473 "Bookmark copy creates bookmark with duplicate guid", which was caused by the fix to this bug.

Comment 8

[Bill Wood]

Hello Dietrich, mano, Samuel, and Mike - have you thought about backing this fix out because of the problem it is causing with non-unique guids in bug 457473? Thanks

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv