try servers need to support building from a mercurial repository with a patch

VERIFIED FIXED

Status

P2
normal
VERIFIED FIXED
10 years ago
5 years ago

People

(Reporter: roc, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [landing on july 11])

Attachments

(1 attachment, 1 obsolete attachment)

The try servers are still pulling from CVS. That means that patches against mozilla-central don't apply anymore.

This wouldn't be so bad if the "build from a Mercurial repository" had an option to take an additional patch to apply. But it doesn't.
(Assignee)

Comment 1

10 years ago
Yeah, that needs to be fixed. I can't give priority to this right now since there's a workaround.
Priority: -- → P3
(Assignee)

Comment 2

10 years ago
To be clear, I think we _do_ want to maintain CVS try server (at least until the build environment changes incompatibly), but we _should_ allow a patch to be applied when pulling from an hg repo.
(Assignee)

Updated

10 years ago
Summary: Try servers pull from CVS → try servers need to support building from a mercurial repository with a patch
Created attachment 328425 [details] [diff] [review]
Add pulling from hg repo with a patch

Untested, but I think this'll do what's needed.  Ben, what's the easiest way to test this?
Attachment #328425 - Flags: review?(bhearsum)
(Assignee)

Comment 4

10 years ago
Comment on attachment 328425 [details] [diff] [review]
Add pulling from hg repo with a patch

I don't have time to give this a full review right now but I scanned over it and it seems OK.

We've got a try server staging environment that we can test it on.
Any progress on getting this set up on the staging environment?
(Assignee)

Comment 6

10 years ago
Sorry if there was some confusion, but I have not even tried to get this going in staging yet. I *might* get a chance later this week.
(Assignee)

Comment 7

10 years ago
OK, testing this out today.
(Assignee)

Comment 8

10 years ago
With a few tweaks I've successfully tested this patch with cvs+patch and w/ an alternative hg repo. I did a quick test of m-c+patch which failed. It appears that the patch is never written to a file on the webserver. I don't have time to figure out why tonight, but I'll tackle that tomorrow.

Thanks for doing the initial work here, Vlad, give that I've already tweaked it some I may as well finish it up.
Assignee: nobody → bhearsum
(Assignee)

Comment 9

10 years ago
Created attachment 329070 [details] [diff] [review]
[checked in] try server support for m-c builds w/ patch - cleaned up + tested

Rob, are you up to reviewing this?
Attachment #328425 - Attachment is obsolete: true
Attachment #329070 - Flags: review?(robert)
Attachment #328425 - Flags: review?(bhearsum)
(Assignee)

Comment 10

10 years ago
Comment on attachment 329070 [details] [diff] [review]
[checked in] try server support for m-c builds w/ patch - cleaned up + tested

Oh, I meant to comment about the processchange.pl removal from buildbot-configs/tryserver. I originally imported it there as a local version (ie, with the global vars set properly) of the webtools/buildbot-try script. Looking at it now, it seems more confusing than necessary, so I just got rid of the buildbot-configs/tryserver one and set-up the webtools/buildbot-try one properly.
(Assignee)

Updated

10 years ago
Priority: P3 → P2
Comment on attachment 329070 [details] [diff] [review]
[checked in] try server support for m-c builds w/ patch - cleaned up + tested

Looks ok to me. 

It'd be nice to use the native bbot try features, Try_Jobdir, etc. instead of rolling this all ourselves, once we drop support for CVS/client.mk builds.. I see no reason for the web interface to not call "buildbot try" directly and use bbot's queuing feature, in the glorious trouble-free future.
Attachment #329070 - Flags: review?(robert) → review+
(Assignee)

Comment 12

10 years ago
(In reply to comment #11)
> (From update of attachment 329070 [details] [diff] [review])
> Looks ok to me. 
> 
> It'd be nice to use the native bbot try features, Try_Jobdir, etc. instead of
> rolling this all ourselves, once we drop support for CVS/client.mk builds.. I
> see no reason for the web interface to not call "buildbot try" directly and use
> bbot's queuing feature, in the glorious trouble-free future.
> 

Yeah, I totally agree. I've been wanting to do that for awhile..maybe I'll get time some day ;-).
Whiteboard: [landing on july 11]
(Assignee)

Comment 13

10 years ago
Comment on attachment 329070 [details] [diff] [review]
[checked in] try server support for m-c builds w/ patch - cleaned up + tested

Checking in master.cfg;
/cvsroot/mozilla/tools/buildbot-configs/tryserver/master.cfg,v  <--  master.cfg
new revision: 1.16; previous revision: 1.15
done
Removing processchanges.pl;
/cvsroot/mozilla/tools/buildbot-configs/tryserver/processchanges.pl,v  <--  processchanges.pl
new revision: delete; previous revision: 1.1
done
Checking in steps.py;
/cvsroot/mozilla/tools/buildbotcustom/tryserver/steps.py,v  <--  steps.py
new revision: 1.4; previous revision: 1.3
done
Checking in processchanges.pl;
/cvsroot/mozilla/webtools/buildbot-try/processchanges.pl,v  <--  processchanges.pl
new revision: 1.4; previous revision: 1.3
done
Checking in sendchange-ui.pm;
/cvsroot/mozilla/webtools/buildbot-try/sendchange-ui.pm,v  <--  sendchange-ui.pm
new revision: 1.5; previous revision: 1.4
done
Checking in sendchange.cgi;
/cvsroot/mozilla/webtools/buildbot-try/sendchange.cgi,v  <--  sendchange.cgi
new revision: 1.3; previous revision: 1.2
done
Attachment #329070 - Attachment description: try server support for m-c builds w/ patch - cleaned up + tested → [checked in] try server support for m-c builds w/ patch - cleaned up + tested
(Assignee)

Comment 14

10 years ago
OK, I've updated the web server and buildbot master. Thanks again for the patch, Vlad.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Depends on: 446168
Verfied with a tryserver build from dao yesterday:
https://build.mozilla.org/tryserver-builds/2008-08-05_14:56-dgottwald@mozilla.com-prefs_apps_search/
Status: RESOLVED → VERIFIED
Component: Try Server → Release Engineering
Product: Webtools → mozilla.org
QA Contact: try-server → release
Version: Trunk → other
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.