437358 - Use native platform colors for URLs in the location bar autocomplete

Status: VERIFIED FIXED

Description

[Aditya Kavoor]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5) Gecko/2008050509 Firefox/3.0b5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5) Gecko/2008050509 Firefox/3.0b5

Beta versions had a green- white color scheme in location bar. this was too good.
The location bars in RC has a white-white color scheme which is bad. Please change it.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Jo Hermans]

what theme are you using ?

Comment 2

[Aditya Kavoor]

I am using the default Ubuntu Human theme.

Here is a acreenshot. See the difference between the Beta5 version and RC2 version.

http://img357.imageshack.us/my.php?image=screenda2.jpg

Comment 4

[Dão Gottwald [::dao]]

Bug 409974 was about the use of hard coded colors, which caused problems with certain OS themes. That bug is fixed now. GrayText isn't ideal, though, so this bug is still valid and not a duplicate.

Comment 5

[Aditya Kavoor]

Created attachment 324116 [details]
Screenshot showing differences between beta 5 and RC2

Comment 6

[Sylvain Pasche]

If you prefer the old appearance, you can use the following userChrome (see http://support.mozilla.com/en-US/kb/Editing+configuration+files#userChrome_css for instructions):

.ac-url-text {
    color: #336633 !important;
}
.autocomplete-richlistitem {
    border-bottom: 1px solid ThreeDShadow !important;
}

(this is from bug 409974 comment 35)

Comment 7

[Aditya Kavoor]

Created attachment 324139 [details]
Screenshot

I added the code to userchrome.css which indeed gave me what I needed. But I have one problem in that.

When the mouse moves over a particular website in the location bar drop down menu, both the website title and the website address should change color to black there by making it different from the rest.

Comment 9

[Dão Gottwald [::dao]]

Created attachment 329283 [details] [diff] [review]
use -moz-nativehyperlinktext

Note that -moz-nativehyperlinktext falls back to #144fae on OS X.

Comment 10

[Ryan A. C.]

Note that on Vista it was decided in Bug 432757 to use a darker than normal color for .ac-url-text. We might want to leave some of the windows-default-theme fu in there for that. Beltzner?

Comment 11

[Dão Gottwald [::dao]]

Umm, yeah, I expected such things but forgot about that particular bug.

FWIW: We now have the native color that we were trying to hardcode and we should use it unless the native color is broken somehow. Making a native color slightly darker doesn't seem like a proper use case for windows-default-theme. See bug 426660 comment 25. See also bug 431666 comment 5.

Comment 12

[Dão Gottwald [::dao]]

Created attachment 331900 [details] [diff] [review]
use -moz-nativehyperlinktext in most cases

Talked to beltzner, on XP we're going to stick with green for now.

Comment 13

[Dão Gottwald [::dao]]

http://hg.mozilla.org/index.cgi/mozilla-central/rev/b89f457f432e

Comment 14

[Stephen Donner [:stephend]]

Verified FIXED using:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b2pre) Gecko/20081020 Minefield/3.1b2pre

on:

mozilla@mozilla-qa:~$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 8.04.1
Release:	8.04
Codename:	hardy

with Human, Mist, Clearlooks, Crux, etc. (in all cases, the URL, as well as the other elements in the location bar, was easy to read, even with the High Contrast themes).

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081020 Minefield/3.1b2pre

Default Windows XP theme has URLs in green; "Windows Classic" returns the URLs' colors to blue.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081020 Minefield/3.1b2pre

Vista's default URL color is blue, and again, "Windows Classic" returns the URLs' colors to blue.

And, finally, on both XP and Vista, I spot-checked high-contrast color schemes, and we respected (and reflected) the color schemes there.

Comment 15

[Stephen Donner [:stephend]]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081020 Minefield/3.1b2pre should be the last build ID, sorry.