437372 - Fennec should implement psm security error ui

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Oleg Romashin (:romaxa)]

Currently Fennec does not have proper PSM ui implementation for handling cert errors.

We have to put preference for using error pages and add netError.dtd override with implementation...

Comment 1

[Oleg Romashin (:romaxa)]

browser.xul.error_pages.enabled - should be enabled to get rid of ugly alert dialog showing..

Comment 2

[Johnathan Nightingale [:johnath]]

Attachment: Straight port from Firefox

This gives us the buttons, strings, and browser.js logic to mimic Firefox's handling.  It's not clear to me if that's the best outcome on this platform, but it is substantially better than what we have now, which is nothing.  :)

The string duplication is an annoying side effect of the way netError.xhtml is built, and the browser.js code is a way for us to handle in-content events with chrome privilege, when appropriate.

Comment 3

[Neil Deakin]

Comment on attachment 331162 [details] [diff] [review]
Straight port from Firefox

Are all those strings used? Or did you just copy the dtd file?

Do we not need to worry about the case where the homepage is changed?

Comment 4

[Johnathan Nightingale [:johnath]]

(In reply to comment #3)
> (From update of attachment 331162 [details] [diff] [review])
> Are all those strings used? Or did you just copy the dtd file?

The way that override works on netError, if you decide to provide your own strings anywhere in that dtd, you get to provide them everywhere in that dtd - you can't do per-entity overrides.  So yes, they are used, because yes, I did just copy the dtd file.  :)

> Do we not need to worry about the case where the homepage is changed?

Hrmph - yeah, we should probably use the default branch there, not gPrefService, that way we end up at a known-good page.

Comment 5

[Neil Deakin]

Comment on attachment 331162 [details] [diff] [review]
Straight port from Firefox

New patch coming I'm told

Comment 6

[Johnathan Nightingale [:johnath]]

Attachment: Use default branch, un-bitrot

Uses the default branch to get the pref.  A lot of the generic event handling code has moved to browser-ui.js in the interim, but this isn't really "UI" in the way that scroll events and onmousedown are, so I kept this code in browser.js and just removed the parts that hooked into the Browser-wide handleEvent().

I've confirmed that this does do the basics, get me out of here, exception adding, but it's not really optimal for mobile, and my testing shows (unsurprisingly) that Fennec is just as beset upon by bug 431712 as Firefox is.  Annoying.  Still, this patch is better than not having this patch.

Comment 7

[Johnathan Nightingale [:johnath]]

Attachment: Patch v2, complete this time

Whoops - last version didn't have the added netError.dtd file

Comment 8

[Johnathan Nightingale [:johnath]]

http://hg.mozilla.org/mobile-browser/rev/acfb6fb2a4ef

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

verified with 1.9.2 20091001 beta4 on my n810

Comment 10

[Tony Chung [:tchung]]

can someone point me to what the psm security error UI should look like?  im trying to put together a manual testcase with steps to verify this.  thanks.

Comment 11

[Martijn Wargers (dead)]

I'm reassigning this to myself for adding litmus testcases for this (aakashd discussed this on irc with blassey and ted on #mobile).