Closed
Bug 437441
Opened 16 years ago
Closed 16 years ago
Finalize calendar-timezones.xpi
Categories
(Calendar :: Build Config, defect)
Calendar
Build Config
Tracking
(Not tracked)
VERIFIED
FIXED
0.9
People
(Reporter: dbo, Assigned: ause)
References
Details
(Keywords: fixed1.8.1.18)
Attachments
(5 files, 3 obsolete files)
1.43 KB,
patch
|
ause
:
review+
|
Details | Diff | Splinter Review |
4.52 KB,
patch
|
dbo
:
review+
|
Details | Diff | Splinter Review |
534 bytes,
patch
|
ted
:
review+
dveditz
:
approval1.8.1.18+
|
Details | Diff | Splinter Review |
2.21 KB,
patch
|
dbo
:
review+
|
Details | Diff | Splinter Review |
511 bytes,
patch
|
Details | Diff | Splinter Review |
This includes - doing multi-l10n builds of the xpi: <http://mxr.mozilla.org/seamonkey/source/calendar/timezones/locales/Makefile.in#43> - adding proper icon and update-url to install.rdf <http://mxr.mozilla.org/seamonkey/source/calendar/timezones/install.rdf#68> - investigating into making sunbird lightning xpi stub dependent on calendar-timezones.xpi. An em:require hinders Sunbird from preinstalling any xpi (including DOM inspector) <http://mxr.mozilla.org/seamonkey/source/calendar/sunbird/app/profile/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/install.rdf.in#63>
Flags: blocking-calendar0.9+
Comment 1•16 years ago
|
||
Similar to lightning's Makefile.in
Attachment #328744 -
Flags: review?(ause)
Comment 2•16 years ago
|
||
The only blocking part of this bug is adding the proper update-url, everything else is optional.
Assignee: nobody → philipp
Keywords: uiwanted
Updated•16 years ago
|
Assignee: philipp → mschroeder
Comment 3•16 years ago
|
||
(In reply to comment #0) > This includes > - doing multi-l10n builds of the xpi: Does this bug include doing l10n of calendar-timezones (not xpi, but extension) which is shipped with Sunbird?
Reporter | ||
Comment 4•16 years ago
|
||
No, the preinstalled calendar-timezones.xpi (in Sunbird) does not need to include all locales other than Sunbird's. But once we release a calendar-timezones.xpi via AMO, that one should include all locales, to fit into every localized Sunbird or Thunderbird/Lightning.
Reporter | ||
Comment 5•16 years ago
|
||
Stefan mentioned on IRC that we could leave the updateURL blank, which will lead the update pings to AMO by default. However it makes sense to push the calendar-timezones.xpi to AMO for testing purposes, e.g. whether an older Sunbird nightly (having a preinstalled 0.1.2007b) properly updates to our current 0.1.2008d (from AMO). IMO we should do that when l10n is ready.
Comment 6•16 years ago
|
||
(In reply to comment #4) > No, the preinstalled calendar-timezones.xpi (in Sunbird) does not need to > include all locales other than Sunbird's. The preinstalled calendar-timezones should include at least a locale which is same as Sunbird, but current nightly l10n Sunbird's calendar-timezones includes only en-US. The reason is: The en-US Sunbird is built first, and then l10n Sunbird is made from en-US Sunbird by repackaging. The repackaging process is repackaging application's locale, but not repackaging extension's locale. As for DOMi which is shipped with Fx2, multi-l10n is done because of this.
Comment 7•16 years ago
|
||
Currently only en-US timezone names are shipped with Sunbird/Lightning nightly builds. This also applies to localized Sunbird nightly builds. Therefore localized Sunbird nightly builds are not usable because the properties can't be found. The visible error is the same as in Bug 437692. As mentioned in that bug I suggest to use a save fallback, e.g. by displaying the raw timezone property name instead of throwing hundreds of errors. The calendar-timezones.xpi included in Sunbird must include all locales that are available for Sunbird. Or the calendar-timezones.xpi must be repackaged for each Sunbird locale to contain the correct files.
Reporter | ||
Comment 8•16 years ago
|
||
Even if we would fall back showing the plain TZID, the localizers can't test whether translation has been correct, right? (In reply to comment #7) > The calendar-timezones.xpi included in Sunbird must include all locales that I think that's hardly doable in the nightlies, IIRC from lightning. > are available for Sunbird. Or the calendar-timezones.xpi must be repackaged for > each Sunbird locale to contain the correct files. I think so.
Reporter | ||
Comment 9•16 years ago
|
||
(In reply to comment #7) > Currently only en-US timezone names are shipped with Sunbird/Lightning nightly > builds. This also applies to localized Sunbird nightly builds. > > Therefore localized Sunbird nightly builds are not usable because the > properties can't be found. The visible error is the same as in Bug 437692. As > mentioned in that bug I suggest to use a save fallback, e.g. by displaying the > raw timezone property name instead of throwing hundreds of errors. Stefan, I cannot see "hundreds of errors" using e.g. a recent german Sunbird nightly, though the timezone names are not localized.
Comment 10•16 years ago
|
||
(In reply to comment #9) There is no recent German Sunbird nightly build. The last one available is from 07-May-2008. If you pick an up-to-date build (e.g. the Polish one) and open one of the timezone pickers you'll see the errors.
Reporter | ||
Comment 11•16 years ago
|
||
I'll try that.
Reporter | ||
Comment 12•16 years ago
|
||
Used the polish one from july 17: WFM without errors, but un-l10ned timezones. Anything I am missing?
Assignee | ||
Comment 13•16 years ago
|
||
Assignee | ||
Comment 14•16 years ago
|
||
Comment on attachment 328744 [details] [diff] [review] [checked in] Allow all locales for calendar-timezones.xpi this patch will help to build multi locale timezone extensions once we enable that on the lightning tinderboxes again. won't help for sunbird
Attachment #328744 -
Flags: review?(ause) → review+
Assignee | ||
Comment 15•16 years ago
|
||
might need some more testing...
Assignee | ||
Comment 16•16 years ago
|
||
this one looks good on windows and linux. no idea about mac yet.
Attachment #330041 -
Attachment is obsolete: true
Attachment #330232 -
Attachment is obsolete: true
Updated•16 years ago
|
Attachment #328744 -
Attachment description: Allow all locales for calendar-timezones.xpi → [checked in] Allow all locales for calendar-timezones.xpi
Comment 17•16 years ago
|
||
Comment on attachment 328744 [details] [diff] [review] [checked in] Allow all locales for calendar-timezones.xpi Having troubles checking in...
Attachment #328744 -
Attachment description: [checked in] Allow all locales for calendar-timezones.xpi → Allow all locales for calendar-timezones.xpi
Comment 18•16 years ago
|
||
Comment on attachment 328744 [details] [diff] [review] [checked in] Allow all locales for calendar-timezones.xpi there we go...
Attachment #328744 -
Attachment description: Allow all locales for calendar-timezones.xpi → [checked in] Allow all locales for calendar-timezones.xpi
Assignee | ||
Comment 19•16 years ago
|
||
Comment on attachment 330262 [details] [diff] [review] matching timezone locale for sunbird seems to work on mac too
Attachment #330262 -
Flags: review?(philipp)
Comment 20•16 years ago
|
||
Comment on attachment 330262 [details] [diff] [review] matching timezone locale for sunbird >+bin\extensions\calendar-timezones@mozilla.org\chrome\calendar-timezones-@AB_CD@.jar >+bin\extensions\calendar-timezones@mozilla.org\chrome\chromelist.txt Do we really need to ship the chromelist? r=philipp
Attachment #330262 -
Flags: review?(philipp) → review+
Comment 21•16 years ago
|
||
Summary (for status meeting): - Ause's patch waits for checkin! - I don't know what the status for (multi-)l10n builds is after both build system patches. Philipp, Daniel? - Adding update-url to install.rdf not needed according to comment#5. - We need to test the timezone update via AMO before release. - Adding proper icon to install.rdf does not block the release. - I don't know much about 'investigating into making sunbird lightning xpi stub dependent on calendar-timezones.xpi'. Does this block the release at all? Daniel?
Reporter | ||
Comment 22•16 years ago
|
||
Comment on attachment 330262 [details] [diff] [review] matching timezone locale for sunbird Since ause is on vacation, I'll check this in; chromelist question still pending.
Attachment #330262 -
Attachment description: matching timezone locale for sunbird → [checked in] matching timezone locale for sunbird
Reporter | ||
Comment 23•16 years ago
|
||
(In reply to comment #21) > Summary (for status meeting): > - Ause's patch waits for checkin! done > - I don't know what the status for (multi-)l10n builds is after both build > system patches. Philipp, Daniel? Reading comment #14, we need to build multi-l10n lightning before (Stefan has filed bug 449180 for this). > - I don't know much about 'investigating into making sunbird lightning xpi stub > dependent on calendar-timezones.xpi'. Does this block the release at all? > Daniel? I don't think this part blocks, because it's rather meant to protect users against deinstalling calendar-timezones.xpi, which shouldn't be possible then.
Comment 24•16 years ago
|
||
(In reply to comment #22) > (From update of attachment 330262 [details] [diff] [review]) > Since ause is on vacation, I'll check this in; chromelist question still > pending. > http://ssitter.googlepages.com/tinderbox-l10n-branch Did this checkin cause busted l10n tboxen?
Reporter | ||
Comment 25•16 years ago
|
||
Comment on attachment 330262 [details] [diff] [review] matching timezone locale for sunbird Seems to be the case -- I've backed the changes out again.
Attachment #330262 -
Attachment description: [checked in] matching timezone locale for sunbird → matching timezone locale for sunbird
Comment 26•16 years ago
|
||
The tinderbox error (example from de tinderbox): make[4]: Leaving directory `/cygdrive/c/builds/tinderbox/Sb-Mozilla1.8-l10n/WINNT_5.2_Clobber/mozilla/calendar/locales' make[3]: Leaving directory `/cygdrive/c/builds/tinderbox/Sb-Mozilla1.8-l10n/WINNT_5.2_Clobber/mozilla/calendar/locales' /usr/bin/make -C ../timezones libs-de make[3]: Entering directory `/cygdrive/c/builds/tinderbox/Sb-Mozilla1.8-l10n/WINNT_5.2_Clobber/mozilla/calendar/timezones' make[3]: *** No rule to make target `libs-de'. Stop. make[3]: Leaving directory `/cygdrive/c/builds/tinderbox/Sb-Mozilla1.8-l10n/WINNT_5.2_Clobber/mozilla/calendar/timezones' make[2]: *** [repackage-win32-installer] Error 2 make[2]: Leaving directory `/cygdrive/c/builds/tinderbox/Sb-Mozilla1.8-l10n/WINNT_5.2_Clobber/mozilla/calendar/locales' make[1]: *** [repackage-win32-installer-de] Error 2 make[1]: Leaving directory `/cygdrive/c/builds/tinderbox/Sb-Mozilla1.8-l10n/WINNT_5.2_Clobber/mozilla/calendar/locales' make: *** [installers-de] Error 2
Assignee | ||
Comment 27•16 years ago
|
||
i get the same error here if calendar/timezone/Makefile doesn't exist. looks like it isn't generated from Makefile.in at all. there are probably two ways to fix that: - add the according line to allmakefiles.sh in the source root - add a DIRS=../timezone to calendar/locales/Makefile.in or both... i'm not sure if we would get a patch for allmakefiles.sh accepted nor do i know what what side effects a DIRS line may have on a l10n build. also DIRS=../something looks somehow dirty to me... suggestions?
Reporter | ||
Comment 28•16 years ago
|
||
Comment on attachment 330262 [details] [diff] [review] matching timezone locale for sunbird Talking to Ause, we opted to go with dirty DIRS. When moving over to trunk/hg, we have better options to clean this up.
Attachment #330262 -
Attachment description: matching timezone locale for sunbird → [checked in] matching timezone locale for sunbird
Reporter | ||
Comment 29•16 years ago
|
||
Comment on attachment 330262 [details] [diff] [review] matching timezone locale for sunbird backed out, boxes broken again: gmake: *** ../timezones: No such file or directory. Stop. gmake[5]: *** [export] Error 2
Attachment #330262 -
Attachment description: [checked in] matching timezone locale for sunbird → matching timezone locale for sunbird
Assignee | ||
Comment 30•16 years ago
|
||
argl! the position of the DIRS line _must_ be before including config.mk. had it that way here by luck.
No longer depends on: 449180
Assignee | ||
Comment 31•16 years ago
|
||
Attachment #330262 -
Attachment is obsolete: true
Reporter | ||
Comment 32•16 years ago
|
||
Comment on attachment 336072 [details] [diff] [review] [checked in] matching timezone locale for sunbird - now with changed DIRS lines finally seems to build
Attachment #336072 -
Attachment description: matching timezone locale for sunbird - now with changed DIRS lines → [checked in] matching timezone locale for sunbird - now with changed DIRS lines
Attachment #336072 -
Flags: review+
Comment 33•16 years ago
|
||
L10n tinderbixen are burning. creating calendar/locales/../timezones/Makefile make[4]: Entering directory `/cygdrive/c/builds/tinderbox/Sb-Mozilla1.8-l10n/WINNT_5.2_Clobber/mozilla/calendar/timezones' /cygdrive/c/builds/tinderbox/Sb-Mozilla1.8-l10n/WINNT_5.2_Clobber/mozilla/build/cygwin-wrapper /cygdrive/c/moztools/bin/nsinstall /cygdrive/c/builds/tinderbox/Sb-Mozilla1.8-l10n/WINNT_5.2_Clobber/mozilla/calendar/locales/../timezones/timezones.sqlite ../../dist/xpi-stage/locale-ca - locales to build -- ca cs da de es-AR es-ES eu fr ga-IE hu is it ja-JP-mac ja ka ko lt nb-NO nl nn-NO pl pt-BR pt-PT ro ru sk sl sv-SE uk zh-CN zh-TW /usr/bin/make -C locales libs AB_CD=ca XPI_NAME=calendar-timezones USE_EXTENSION_MANIFEST=1 NO_JAR_AUTO_REG=1 make[5]: Entering directory `/cygdrive/c/builds/tinderbox/Sb-Mozilla1.8-l10n/WINNT_5.2_Clobber/mozilla/calendar/timezones/locales' make[5]: *** No rule to make target `libs'. Stop. make[5]: Leaving directory `/cygdrive/c/builds/tinderbox/Sb-Mozilla1.8-l10n/WINNT_5.2_Clobber/mozilla/calendar/timezones/locales' make[4]: *** [libs-ca] Error 2 make[4]: Leaving directory `/cygdrive/c/builds/tinderbox/Sb-Mozilla1.8-l10n/WINNT_5.2_Clobber/mozilla/calendar/timezones' make[3]: *** [libs] Error 2 make[3]: Leaving directory `/cygdrive/c/builds/tinderbox/Sb-Mozilla1.8-l10n/WINNT_5.2_Clobber/mozilla/calendar/locales' make[2]: *** [libs-ca] Error 2 make[2]: Leaving directory `/cygdrive/c/builds/tinderbox/Sb-Mozilla1.8-l10n/WINNT_5.2_Clobber/mozilla/calendar/locales' make[1]: *** [langpack-ca] Error 2 make[1]: Leaving directory `/cygdrive/c/builds/tinderbox/Sb-Mozilla1.8-l10n/WINNT_5.2_Clobber/mozilla/calendar/locales' make: *** [installers-ca] Error 2 make: Leaving directory `/cygdrive/c/builds/tinderbox/Sb-Mozilla1.8-l10n/WINNT_5.2_Clobber/mozilla/calendar/locales'
Comment 34•16 years ago
|
||
Can someone please back this out or fix the underlying issue. Burning l10n tinderboxen are bad.
Reporter | ||
Comment 35•16 years ago
|
||
Calm down, Ause is working on it.
Assignee | ||
Comment 36•16 years ago
|
||
Attachment #336330 -
Flags: review?(ted.mielczarek)
Assignee | ||
Comment 37•16 years ago
|
||
Comment on attachment 336330 [details] [diff] [review] [checked in] two more calendar directories to generate makefiles what additional approval do i need for MOZILLA_1_8_BRANCH ?
Updated•16 years ago
|
Attachment #336330 -
Flags: approval1.8.1.17?
Comment 38•16 years ago
|
||
Comment on attachment 336330 [details] [diff] [review] [checked in] two more calendar directories to generate makefiles I heard that the time for 1.8.1.17 approvals has already run out. Therefore I'm requesting approval1.8.1.18 and ask for a timely reaction as we are in the process of pushing out a Calendar release.
Attachment #336330 -
Flags: approval1.8.1.18?
Updated•16 years ago
|
Assignee: mschroeder → ause
Status: NEW → ASSIGNED
Comment 39•16 years ago
|
||
How about reverting the patch until the additional patch gets review and approval? This way the l10n teams and testing community would have nightly builds back for testing.
Updated•16 years ago
|
Attachment #336330 -
Flags: review?(ted.mielczarek) → review+
Updated•16 years ago
|
Whiteboard: [patch in hand] [has review] [needs approval]
Assignee | ||
Comment 40•16 years ago
|
||
Comment 41•16 years ago
|
||
Comment on attachment 336330 [details] [diff] [review] [checked in] two more calendar directories to generate makefiles 1.8.1.17 is cut already, too late for that. Approved for 1.8.1.18 landing on the MOZILLA_1_8_BRANCH, a=dveditz
Attachment #336330 -
Flags: approval1.8.1.18?
Attachment #336330 -
Flags: approval1.8.1.18+
Attachment #336330 -
Flags: approval1.8.1.17?
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: [patch in hand] [has review] [needs approval] → [patch in hand] [has review]
Attachment #336464 -
Flags: review?(daniel.boelzle)
Reporter | ||
Updated•16 years ago
|
Attachment #336464 -
Flags: review?(daniel.boelzle) → review+
Attachment #336330 -
Attachment description: two more calendar directories to generate makefiles → [checked in] two more calendar directories to generate makefiles
Assignee | ||
Comment 42•16 years ago
|
||
Comment 43•16 years ago
|
||
checked in patch "after fixing the breakage, fix duplicat packing..." on trunk and Mozilla_1_8_BRANCH
Updated•16 years ago
|
Attachment #336464 -
Attachment description: after fixing the breakage, fix duplicat packing... → [checked in] after fixing the breakage, fix duplicat packing...
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: [patch in hand] [has review]
Reporter | ||
Comment 44•16 years ago
|
||
I think this bug can be marked FIXED; the outstanding dependency will be resolved (or not) with bug 437692.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 45•16 years ago
|
||
Comment on attachment 336637 [details] [diff] [review] add to makefile generation on trunk What about this patch? Is it needed on trunk (or better comm-central)?
Updated•16 years ago
|
Keywords: fixed1.8.1.18
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•