Currently string bundles do not adequately support newlines in strings, and the inf.loop cancellation dialog is in english as a result. Once 21418 is fixed, this code can be converted to use string bundles to contain the error message. Trivial change, important for localisation.
nominating for nsbeta2, we should not have hardcoded english text in the product. talked with this with jst, we both think this is a simple fix given a fix for 21418
Depends on: 21418
Summary: Infinite loop dialog needs to be localisable. → Infinite loop dialog needs to be localisable.
Status: NEW → ASSIGNED
OS: Windows 2000 → All
Hardware: PC → All
Target Milestone: --- → M18
Putting on [nsbeta2+] radar for beta2 fix.
Hi, Johnny: In theory, we shall fix 21418 as I always wish, but, we are running out of timt for PR2, is it possible that you can get around this problem by using the hack Ben mentioned in bug 21418 or use %n% in property file and replace it before passing to UI? If not, we need to fix 21418. But, base on Frank's comment, it is rather risky. Sorry for the inconvenience!
We will worry about this in beta 3... Marking beta2- because we would not pull beta 2 off the wire for this.
Whiteboard: [nsbeta2+][ETA 7/17] → [nsbeta2-][ETA 7/17]
This bug has been marked "future" because the original netscape engineer working on this is over-burdened. If you feel this is an error, that you or another known resource will be working on this bug,or if it blocks your work in some way -- please attach your concern to the bug for reconsideration, but do not clear the nsbeta3- nomination.
Whiteboard: [nsbeta2-][ETA 7/17] → [nsbeta2-][nsbeta3-]
Target Milestone: M18 → Future
Thanks a bunch for the patch, a couple of things about the patch tho: With the patch, if any one thing fails after getting the string bundle service we'll end up interrupting the script execution (by returning !ret). I think it would be better to default to the english text in the dialog and use that in case something fails while getting either of the two strings from the string bundle. I.e. leave the code that's in there and just add code that gets the strings from the string bundle and if that succeeds then replace the default strings with the ones you get from the string bundle. The reasoning behind this is that it's better to show the dialog in english than not showing it at all in the case where we're unable to get the strings from the string bundle.
Okay, okay, jst convinced me that translators aren't perfect. Taking this and I'll do it later...
Assignee: jst → blakeross
Status: ASSIGNED → NEW
Keywords: nsbeta2, nsbeta3
Assignee: bross2 → general
Status: ASSIGNED → NEW
QA Contact: doronr → general
Assignee: general → nobody
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Component: General → Localization
Product: SeaMonkey → Core
QA Contact: general → localization
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.