437483 - Add targetPlatform to install.rdf

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Philipp Wagner [:imphil]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.14) Gecko/20080410 SUSE/2.0.0.14-0.1 Firefox/2.0.0.14
Build Identifier: 

The install.rdf file provides a way to specify for which OS and architecture an extension has been built (http://developer.mozilla.org/en/docs/install.rdf#targetPlatform). This is quite useful for XForms, as the extension manager rejects the extension if you try to install it on a wrong platform. Currently, installing a Linux x86 extension on a x86_64 machine seems to work, but no form will render. By adding the targetPlatform to the install.rdf, this confusion can be avoided.

Reproducible: Always

Comment 1

[Philipp Wagner [:imphil]]

Attachment: install targetPlatform to install.rdf

Comment 2

[aaronr]

Comment on attachment 323913 [details] [diff] [review]
install targetPlatform to install.rdf

Looks just like what calendar does so I assume it is right :-)

This patch is for both 1.8 branch and trunk, right?

Comment 3

[Philipp Wagner [:imphil]]

Yes, it's for 1.8 and trunk.

Comment 4

[Reed Loden [:reed]]

CVS HEAD (1.9.0 branch):

Checking in extensions/xforms/Makefile.in;
/cvsroot/mozilla/extensions/xforms/Makefile.in,v  <--  Makefile.in
new revision: 1.77; previous revision: 1.76
done
Checking in extensions/xforms/install.rdf;
/cvsroot/mozilla/extensions/xforms/install.rdf,v  <--  install.rdf
new revision: 1.4; previous revision: 1.3
done

CVS MOZILLA_1_8_BRANCH:

Checking in extensions/xforms/Makefile.in;
/cvsroot/mozilla/extensions/xforms/Makefile.in,v  <--  Makefile.in
new revision: 1.38.2.19; previous revision: 1.38.2.18
done
Checking in extensions/xforms/install.rdf;
/cvsroot/mozilla/extensions/xforms/install.rdf,v  <--  install.rdf
new revision: 1.1.4.7; previous revision: 1.1.4.6
done