Closed Bug 437488 Opened 18 years ago Closed 17 years ago

Ability to report a suspected phishing/malware site

Categories

(Camino Graveyard :: Security, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Camino2.0

People

(Reporter: murph, Assigned: murph)

References

Details

(Whiteboard: l10n [camino-2.0])

Attachments

(3 files, 2 obsolete files)

As mentioned over on Bug 358299 comment 14, we can hook up an element in our interface to give the user the ability to report a suspected phishing or malware site. Suspected URLs should be reported to the active safe browsing data provider, and appropriate report URLs for each provider are stored in preferences. (The actual URL formation, which parameters it takes and so on, will be identical since each data provider is implementing Google's Safe Browsing Protocol - it's merely the actual host that will be changing). The user should be redirected to a form on the data provider's site, and ideally we'd populate everything we could in advance. See http://code.google.com/apis/safebrowsing/developers_guide.html#ReportingData. Firefox uses the following fill URL for reporting: > http://www.google.com/safebrowsing/report_phish/?tpl=mozilla&continue=http%3A%2F%2Fwww.google.com%2Ftools%2Ffirefox%2Ftoolbar%2FFT2%2Fintl%2Fen%2Fsubmit_success.html&hl=en-US&url=%@ "%@" is the token the form will use to pre-fill in the evil URI. Note that this bug is about reporting a site that does not yet exist in the data provider's blacklist, one that the user feels should be. The other type of report, informing the provider about a false-positive, should most likely be offered by the about:safebrowsingblocked nsIAboutModule. I'm leaving that for another bug, since the process differs.
Hardware: Macintosh → All
We should pick up the changes for bug 438655 here, if we haven't already by the time we fix this.
I think we want this, but I don't know right now that we'll block on it.
Flags: camino2.0b2?
Whiteboard: l10n
Since we'll be messing with URLs when fixing this bug, we should also make sure that all of the buttons on the overlay page and blocker bar go to the "right" places. Below are the current (as of bug 441733) URLs: 1) Overlay page a) Phishing i) Why is this site blocked? - http://en-us.www.mozilla.com/en-US/firefox/phishing-protection/ ii) Get me out of here! - Home b) Malware i) Why is this site blocked? - http://google.com/safebrowsing/diagnostic?tpl=Camino&site=http://caminobrowser.org/documentation/security/test-malware/&hl=en ii) Get me out of here! - Home 2) Blocker bar a) Phishing i) Get me out of here! - Home ii) Report an error… - http://www.google.com/safebrowsing/report_error/?tpl=generic&continue=http://caminobrowser.org/security/report-submitted.php&url=http://caminobrowser.org/documentation/security/test-phishing/&hl=en b) Malware i) Get me out of here! - Home ii) Report an error… - http://google.com/safebrowsing/diagnostic?tpl=Camino&site=http://caminobrowser.org/documentation/security/test-malware/&hl=en 1.a.i and 2.b.ii are the two that seem like they need to be fixed.
Target Milestone: --- → Camino2.0
Assignee: nobody → murph
(In reply to comment #3) I've been thinking about the URL situation. Here are my current thoughts: For many cases, I'm not sure if we either need (or should) provide a distinction between malware and phishing pages. I mostly say this in reference to the "why was this site blocked" buttons, as well as reporting nasty URLs not yet blocked. Most users probably either do not know the difference or seek to understand it. In prefs, we will not indicate a distinction (just a global safe browsing enabled option). Branding and explaining the blocking more generally as just safe browsing, in many cases, seems like the right approach. When it comes to the "why was this site blocked," I think it should forward to something like http://caminobrowser.org/documentation/security/#safebrowsing where we can explain under the general title of "safe browsing," under which we can mention specifically phishing and malware. As for reporting, not only is it confusing to allow reporting phishing AND malware, there's no handy form for submitting malware sites. The latter is done with Google's webmaster tools. I think we should, just as Firefox does, only offer reporting for not yet blocked phishing URLs. So, my new proposal: "Why was this site blocked" for both malware and phishing -> http://caminobrowser.org/documentation/security/#safebrowsing (Malware currently goes to the malware diagnostic page, but that's highly technical and aimed more at the webmaster; I'd rather us explain the blocking). Report an error (Phishing) -> Google's form Report an error (Malware) -> Malware diagnostic page (In this case, I do believe the diagnostic page should be used. It's really the only place where the webmaster can learn how to fix the problem.). Also, the "Get me out" buttons currently attempt to go back in history first, and if there's no history then home. We'll have to make sure we want to continue offering the back, in cases of quick redirection or similar security implications.
I'm going to use Hendy's -[BrowserWrapper isBlockedOverlayShowing] method in bug 501246 for menu validation here. Setting up the dependency.
Depends on: 501246
Attached patch Patch (obsolete) — — Splinter Review
Adds reporting via a menu item: "Help->Report Phishing Page…"
Attachment #391139 - Flags: review?(stuart.morgan+bugzilla)
Attached file MainMenu.nib [bitrotted] (obsolete) —
New MainMenu.nib. Note that this was created with IB 3.x on Leopard. I believe we will need someone on Tiger to open this and re-save under IB 2.x.
Attachment #391139 - Flags: review?(stuart.morgan+bugzilla) → review+
Comment on attachment 391139 [details] [diff] [review] Patch >+// Reports the current page as one suspected of phishing. Move this to the header. >+ if (reportURL) >+ [self loadURL:reportURL referrer:nil focusContent:YES allowPopups:NO]; Fix indentation. >+// Returns YES if the current page is reasonable to report to the safe browsing >+// data provider as a suspected phishing site. Move to header. >+ // Check for error overlays >+ if ([browserWrapper isBlockedErrorOverlayShowing] || [browserWrapper isPageLoadErrorOverlayShowing]) Code is self-explanatory, so this comment can go. >+ // Simple URL validation to report only URLs with a HTTP scheme and not >+ // internal, data:, or javascript: URLs, for instance... >+ NSString* currentURI = [browserWrapper currentURI]; >+ if (!([currentURI hasPrefix:@"http://"] || [currentURI hasPrefix:@"https://"])) Same, especially since this is the kind of comment that's likely to get out-of-date relative to the code--in fact, it already is ;) r=me on the code with those changes, if someone can build and give this a spin.
Attached patch Patch, v2 — — Splinter Review
Updated patch with Stuart's comments addressed.
Attachment #391139 - Attachment is obsolete: true
Attachment #391877 - Flags: superreview?(mikepinkerton)
Flags: camino2.0b4? → camino2.0b4+
Comment on attachment 391142 [details] MainMenu.nib [bitrotted] This has now been bitrotted by bug 452557, so we'll need a new one before checkin.
Attachment #391142 - Attachment description: MainMenu.nib → MainMenu.nib [bitrotted]
Comment on attachment 391877 [details] [diff] [review] Patch, v2 sr=pink very sorry for the delay. the out of band request got lost in my flood of vacation mail.
Attachment #391877 - Flags: superreview?(mikepinkerton) → superreview+
Attached file MainMenu.nib —
New MainMenu.nib, refreshed with external changes. Note: This was created in IB 3.x on Leopard and will need to be re-saved in IB 2.x on 10.4.
Attachment #391142 - Attachment is obsolete: true
Checked in on cvs trunk and CAMINO_2_0_BRANCH. Keeping a close eye on Ts…
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: l10n → l10n [camino-2.0]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: