Closed Bug 437593 Opened 16 years ago Closed 16 years ago

invitations link should be provided in mail mode too.

Categories

(Calendar :: Calendar Frontend, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: berend.cornelius09, Assigned: berend.cornelius09)

Details

Attachments

(1 file, 1 obsolete file)

According to our roadmap document available under http://wiki.mozilla.org/Calendar:Lightning09#Calendar_Views

the invitations link should be provided in all modes.
As Christian suggested the implementation should also provide a menu-item in the "View-Menu" to toggle the display mode-dependently  similar to the minimonth and calendar-list.
Attached patch patch v. #1 (obsolete) — Splinter Review
I implemented this by making use of a modebox that I wrapped around the invitations-link
Attachment #324014 - Flags: review?(philipp)
Attachment #324014 - Flags: ui-review?(christian.jansen)
Flags: wanted-calendar0.9+
Berend, maybe you can move the CSS rule for '.calendar-invitations-sidebar-label' from '/calendar/prototypes/themes/winstripe/sun-messenger-overlay-sidebar.css' to '/calendar/lightning/themes/winstripe/lightning.css', and remove sun-messenger-overlay-sidebar.css.
Attached patch patch v. #2Splinter Review
Very good idea. Made a new patch.
Attachment #324014 - Attachment is obsolete: true
Attachment #324025 - Flags: ui-review?(christian.jansen)
Attachment #324025 - Flags: review?(philipp)
Attachment #324014 - Flags: ui-review?(christian.jansen)
Attachment #324014 - Flags: review?(philipp)
Comment on attachment 324025 [details] [diff] [review]
patch v. #2

>+      <label id="invitations"
>+             class="text-link calendar-invitations-sidebar-label"
>+             value="&lightning.sidebar.invitations.label;"
>+             onclick="openInvitationsDialog();"/>
>+      <spacer flex="1"/>
Instead of a spacer, you could probably use pack="start" as an attribute on the label.
>     <toolbox id="mode-toolbox" location="bottom" mode="full">

r=philipp
Attachment #324025 - Flags: review?(philipp) → review+
Status: NEW → ASSIGNED
Comment on attachment 324025 [details] [diff] [review]
patch v. #2

Looks ok for me. thanks for the patch. ui=christian
Attachment #324025 - Flags: ui-review?(christian.jansen) → ui-review+
In reply to comment #4: 
The spacer was to have the focusring only over the label and not the entire box

patch checked in on trunk and MOZILLA_1_8_BRANCH
->FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
checked in lightning build 2008061203 -> VERIFIED
Status: RESOLVED → VERIFIED
Target Milestone: --- → 0.9
Hi
Sorry to ask here on a closed bug, but could anybody explain how this invitation links work? Or point me to a page where this is explained. I can see this link, but there is nothing behind! And then it disappears once click.
Thanks and sorry again :)
(In reply to comment #8)
> could anybody explain how this invitation link works?

I think it's only for WCAP calendars (and similar providers) that don't use email-based invitations.  Since I only use ICS, I've disabled the Invitations Link in Mail/Calendar/Tasks modes (via the View menu).
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: