437593 - invitations link should be provided in mail mode too.

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Berend Cornelius]

According to our roadmap document available under http://wiki.mozilla.org/Calendar:Lightning09#Calendar_Views

the invitations link should be provided in all modes.
As Christian suggested the implementation should also provide a menu-item in the "View-Menu" to toggle the display mode-dependently  similar to the minimonth and calendar-list.

Comment 1

[Berend Cornelius]

Attachment: patch v. #1

I implemented this by making use of a modebox that I wrapped around the invitations-link

Comment 2

[Martin Schröder [:mschroeder]]

Berend, maybe you can move the CSS rule for '.calendar-invitations-sidebar-label' from '/calendar/prototypes/themes/winstripe/sun-messenger-overlay-sidebar.css' to '/calendar/lightning/themes/winstripe/lightning.css', and remove sun-messenger-overlay-sidebar.css.

Comment 3

[Berend Cornelius]

Attachment: patch v. #2

Very good idea. Made a new patch.

Comment 4

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 324025 [details] [diff] [review]
patch v. #2

>+      <label id="invitations"
>+             class="text-link calendar-invitations-sidebar-label"
>+             value="&lightning.sidebar.invitations.label;"
>+             onclick="openInvitationsDialog();"/>
>+      <spacer flex="1"/>
Instead of a spacer, you could probably use pack="start" as an attribute on the label.
>     <toolbox id="mode-toolbox" location="bottom" mode="full">

r=philipp

Comment 5

[Christian Jansen]

Comment on attachment 324025 [details] [diff] [review]
patch v. #2

Looks ok for me. thanks for the patch. ui=christian

Comment 6

[Berend Cornelius]

In reply to comment #4: 
The spacer was to have the focusring only over the label and not the entire box

patch checked in on trunk and MOZILLA_1_8_BRANCH
->FIXED

Comment 7

[Andreas Treumann]

checked in lightning build 2008061203 -> VERIFIED

Comment 8

[klint]

Hi
Sorry to ask here on a closed bug, but could anybody explain how this invitation links work? Or point me to a page where this is explained. I can see this link, but there is nothing behind! And then it disappears once click.
Thanks and sorry again :)

Comment 9

[Pete Riley]

(In reply to comment #8)
> could anybody explain how this invitation link works?

I think it's only for WCAP calendars (and similar providers) that don't use email-based invitations.  Since I only use ICS, I've disabled the Invitations Link in Mail/Calendar/Tasks modes (via the View menu).