Closed
Bug 437855
Opened 17 years ago
Closed 17 years ago
CEIP shouldn't use .key for accesskeys
Categories
(Other Applications Graveyard :: ChatZilla, defect)
Other Applications Graveyard
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wladow, Assigned: wladow)
Details
(Keywords: polish, Whiteboard: [cz-0.9.83])
Attachments
(2 files)
|
2.19 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
|
2.68 KB,
patch
|
Details | Diff | Splinter Review |
CEIP dialog uses .key as identifier for accesskeys. This isn't right, .key means commnadkey, we should use .accesskey identifier. L10n tools complain about it too.
Attachment #324192 -
Flags: review?(gijskruitbosch+bugs)
Comment 1•17 years ago
|
||
Comment on attachment 324192 [details] [diff] [review]
patch -w
r=me
Do you need me to check this in for you, or do you have CVS checkin privileges yourself, for the main CVS repo?
Attachment #324192 -
Flags: review?(gijskruitbosch+bugs) → review+
| Assignee | ||
Comment 2•17 years ago
|
||
Yes pls, check it in. I propose to use this patch - it's the same patch as previous, but without ignoring whitespace changes.
| Assignee | ||
Updated•17 years ago
|
Keywords: checkin-needed
Comment 3•17 years ago
|
||
Checking in mozilla/extensions/irc/locales/en-US/chrome/ceip.dtd;
/cvsroot/mozilla/extensions/irc/locales/en-US/chrome/ceip.dtd,v <-- ceip.dtd
new revision: 1.2; previous revision: 1.1
done
Checking in mozilla/extensions/irc/xul/content/ceip/config.xul;
/cvsroot/mozilla/extensions/irc/xul/content/ceip/config.xul,v <-- config.xul
new revision: 1.2; previous revision: 1.1
done
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [cz-0.9.83]
Updated•1 year ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•