437919 - Omnibus ad-blocking bug for June/July 2008

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Here an ad, there an ad, everywhere an ad-ad…

Comment 1

[Chris Lawson (gone)]

New Flash ads on freep.com from adtechus.com:

http://www.freep.com/apps/pbcs.dll/article?AID=/20080611/SPORTS03/80611062/1118/rss

Ad coming from:

http://aka-cdn-ns.adtechus.com/apps/369/Ad50545St3Sz154Sq208814V0Id3/160x600_Detroit.swf?targetTAG =_blank&clickTarget=_blank&athTAG=http%3A//aka-c dn-ns.adtechus.com/apps/369/Ad50545St3Sz154Sq208814V0Id3&closeTAG=javascript%3AcloseAdLayer215373%28%29&openTAG=javascript%3AopenAdLayer215373%28%29&expandTAG=javascript%3Aexpand215373%28%29&coll apseTAG=javascript%3Acollapse215373%28%29&clickta rget=_blank&clickTarget=_blank&clickTARGET=_blank&CURRENTDOMAIN=www.freep.com

I suspect we could, in theory, block the entire adtechus.com domain, although I'm not sure we want to be that aggressive. (The alternative may be to play whack-a-mole with the many adtechus.com ad servers.)

cl

Comment 2

[Chris Lawson (gone)]

Ads on Hulu.com:

http://www.hulu.com/watch/18951/family-guy-long-john-peter

Coming from:

http://stats5.lightningcast.com/servlets/getElement?creativeid=72648&streamid=88900&formatid=44&bId=305598&upid=A8CWRb7SUxSQbLEx3vyid_Ux&ioid=63156&region=AU300x60&resp=REDIR&fr=1213231738722&content=7541711&geo=49001&&attr=%5BDaypart%2CPrime+Time%5D%5BContentProvider%2CFBC%5D%5BSeries%2CSH002960010000%5D%5BEpisode%2CEP002960010117%5D%5BContentID%2C7541711%5D%5Brating%2CTV-14%5D%5Bcontenttype%2Cnon-promo%5D%5BAdModel%2Clongform%5D%5Bpid%2CW0Jrp1RG5ihhJCAcIhzDVtz8_7f1lq9H%5D%5BDistro%2Chulu%5D%5BPod%2C0%5D%5BDistroPlatform%2CHulu%5D%5Bplaylocation%2Csite%5D%5Bacceptbanner%2Ctrue%5D%5Bbrand%2CRandom%5D%5Bversion%2C2%5D%5Benv%2Cprod%5D&ext=.html

for example.

Comment 3

[philippe (part-time)]

Movies not visible on 
http://www.apple.com/ipodtouch/ads/

They are wrapped in a div[id="ad"]

That one was added in bug 387424, if I'm not wrong.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #3)
> Movies not visible on 
> http://www.apple.com/ipodtouch/ads/
> 
> They are wrapped in a div[id="ad"]

Fun :P  We can add that to our existing Apple exception, I guess.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #4)
> (In reply to comment #3)
> > Movies not visible on 
> > http://www.apple.com/ipodtouch/ads/
> > 
> > They are wrapped in a div[id="ad"]
> 
> Fun :P  We can add that to our existing Apple exception, I guess.

Given that it's Apple, we might want to cherry-pick that rule for 1.6.2.

Comment 6

[philippe (part-time)]

(In reply to comment #5)

> Given that it's Apple, we might want to cherry-pick that rule for 1.6.2.
> 

I filed bug 439793 for that one.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I cross-landed bug bug 439793 for comment 3-6 so we wouldn't be in a weird position two months hence trying to figure out what needed to land on branch for 1.6.3.

Comment 8

[Chris Lawson (gone)]

Ads on sltrib.com, for example:

http://www.sltrib.com/news/ci_9714554 (the "improve your credit" Flash skyscraper on the right)

Coming from 

<iframe src="http://preview.leadmediapartners.com/nac/tribune/education/pilot_ad.html" scrolling="no" width="160" height="600" frameborder="0"></iframe>

Comment 9

[Chris Lawson (gone)]

Lots of ads on this article

http://www.herald-dispatch.com/sports/x1103451892/Rodriguez-deal-leaves-funny-smell-in-Michigan

pretty much all coming from crow.herald-dispatch.com or media.herald-dispatch.com/AdList/ .

Comment 10

[Chris Lawson (gone)]

Text ads on IMDB in a "sponsored links" block coming from

<iframe src="http://content.pulse360.com/C6C7561A-492E-11DD-9179-2C743BF8694A" width="410" height="245" frameborder="0" scrolling="no"></iframe>

Example on

http://www.imdb.com/name/nm2105255/bio

Comment 11

[philippe (part-time)]

(random) ads on the NYT
http://www.nytimes.com/2008/07/15/opinion/15brown.html?_r=1&oref=slogin

The link is pointing to 
http://www.nytimes.com/adx/bin/adx_click.html?
image comes from
http://graphics8.nytimes.com/adx/images/ADS

nested in div[id="adxLeaderboard"] (masthead) and div[id="adxBigAd"] (sidebar)

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We block Flash and iframes from trafficmp.com, but not images; I've seen a few of them sneaking by.

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On http://news.cnet.com/8301-13509_3-9984637-20.html?hhTest=1

iframe[src*="bwp.cnet.com"]

(we already block the versiontracker and macfixit versions of this ad-frame server)

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #1)
> New Flash ads on freep.com from adtechus.com:

> I suspect we could, in theory, block the entire adtechus.com domain, although
> I'm not sure we want to be that aggressive. (The alternative may be to play
> whack-a-mole with the many adtechus.com ad servers.)

I think we'll just whack the whole thing at once; adding that specific server is ugly.

 (In reply to comment #2)
> Ads on Hulu.com:

div[id^="banner-ad"] gets that.

(In reply to comment #9)

> pretty much all coming from crow.herald-dispatch.com or
> media.herald-dispatch.com/AdList/ .

With all due respect to the good people of Huntington and members of the Thundering Herd, I can't see blocking something as site-specific as foo.herald-dispatch.com, and there's nothing in the ad-rotator url that seems blockable, either.  We can block about half of the ads there with rules that are more generic (could apply widely), but this half will need to be custom userContent-type rules.

(In reply to comment #11)
> (random) ads on the NYT

> nested in div[id="adxLeaderboard"] (masthead) and div[id="adxBigAd"] (sidebar)

I made those ^ rules to catch the "adxBigAd2" and friends id variants.

Comment 15

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Jun-Jul Omnibus ads

This takes care of everything in this bug and philippe's rule from bug 436766 (with the one exception mentioned in comment 14).

Comment 16

[Simon Fraser [no longer active]]

Comment on attachment 332298 [details] [diff] [review]
Jun-Jul Omnibus ads

You should probably find someone else to review these next time.

Comment 17

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.

Comment 18

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on the MOZILLA_1_8_BRANCH in advance of 1.6.4.