Assignee: nobody → dtownsend
Priority: -- → P2
Target Milestone: Fennec M6 → Fennec M5
Assignee: nobody → mark.finkle
Target Milestone: Fennec A1 → Fennec M7
Created attachment 334218 [details] [diff] [review] WIP: add-on functionality Initial patch for supporting installing, viewing and removing add-ons. It uses a modified XPInstall observer to handle installing from a website. It uses the new preferences to support the "Get Addons" panel in the Add-ons Manager. The main differences/issues are: * We use a panel in the main browser window (uses an iframe to host the manager) so the xpinstall preferences needed to be tweaked a bit. * "Get Addons" doesn't function yet, as AMO has no Fennec addons. * The iframe hosted Add-ons Manager needs some theming to blend in better.
If needed, this patch could be landed as is (after a review) and the theming changes added as a followup bug.
Created attachment 334310 [details] [diff] [review] Add-on features with some simple theming ame as previous patch but adds some simple theming to make the iframed dialog fit better into the style of the app.
Comment on attachment 334310 [details] [diff] [review] Add-on features with some simple theming It pains me to see that gXPInstallObserver code duplicated :( Seems like it would be a good candidate for turning into a module, right? Just pass in the two string bundles and notification box. New bug?
Attachment #334310 - Flags: review?(gavin.sharp) → review+
Yeah a new bug for the module. We add something to the notification callback so it will need a small refactor. I'll file a bug. changeset: 104:28cbb8ab4a2a tag: tip user: Mark Finkle <email@example.com> date: Tue Aug 19 22:18:36 2008 -0400 summary: b=437959, r=gavin. View, install and remove add-ons
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
verified with beta3
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.