438040 - necko should go offline when a computer is about to go to sleep, and come back online when it wakes up

Status: RESOLVED WONTFIX

(Core :: Networking, defect)

Description

[Shawn Wilsher :sdwilsh]

necko should set the offline state appropriately when the computer goes to sleep and wakes up.  This will work out well for windows and mac, but linux currently has no code to dispatch the notification.  The good news is that not doing anything on linux doesn't change our current behavior.

Comment 1

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

I don't think this is right given a few concerns (outlined below), but I think it'll be important to hear from the module owner on this.

Issues:
1) Do we need to care about the fact that we may not be managing offline state?  There appears to be a member variable for that, but I'm not sure it applies in this situation.
2) Should we keep track of us being online or not before going to sleep, and preserve this state upon wakeup?  My gut says yes, but this patch doesn't do this.
3) Do we really want to advertise being online right away?  In the download manager we had a delay before we advertised this to ensure that the network was up and functional.  Can we even check this?

Comment 2

[benc]

A couple comments:

1- Is there a dupe for this already? I'm sure I've seen a couple over the years.

2- What is the problem you are trying to avoid? 

The reason I ask is that, actually, from a classic TCP perspective, a connection only closes in certain cases. A connection where a client stops responding does not explicitly mean the connection must close (although most modern applications will do so to conserve various resources). 

What I'm saying is, if necko were to go to sleep and wake up later, there would not be any explicit reason why it should assume connections are disconnected (unless the OS wipes out the connection table as it goes to sleep...)

3- If you really want to get this fixed, you should probably create 3 platform specific bugs, because there could be a lot of specifics that interest some people, but bore everyone else.

Comment 3

[Michael Kohler [:mkohler]]

This is a mass change. Every comment has "assigned-to-new" in it.

I didn't look through the bugs, so I'm sorry if I change a bug which shouldn't be changed. But I guess these bugs are just bugs that were once assigned and people forgot to change the Status back when unassigning.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 324326 [details] [diff] [review]
v1.0

cleaning up my review queue, please re-request if this is still desired

Comment 5

[Patrick McManus [:mcmanus]]

we deal with network change and sleep events now by clearing a bunch of state.. we don't necessarily change the offline status.