Closed Bug 43821 Opened 24 years ago Closed 24 years ago

PutHeader has unbalanced <TABLE> tags

Categories

(Bugzilla :: Bugzilla-General, defect, P3)

Product:
Bugzilla
Component:
Bugzilla-General
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Bugzilla 2.12

People

(Reporter: tenthumbs, Assigned: justdave)

Details

(Whiteboard: 2.12) 

Open any bug from your browser and look at the source. Line 32 duplicates line
31 like this:

</TD></TR></TABLE>
</TD></TR></TABLE>
dup of 47251

*** This bug has been marked as a duplicate of 47251 ***
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → DUPLICATE
I see nothing in bug 47251 that fixes this problem. Reopening.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
This really should be fixed.
Summary: Bugzilla generates invalid HTML → Bugzilla generates invalid HTML (should fix for 2.12)
Although this could have been included in bug 47251, it wasn't.  Making the 
summary more specific so it doesn't get marked dupe again.  Adding 2.12 and 
copying Chris.
Summary: Bugzilla generates invalid HTML (should fix for 2.12) → bug_form.pl has unbalanced <TABLE> tags
Whiteboard: 2.12
I found this...  it's in CGI.pl rather than bug_form.pl.  The PutHeader() 
routine, to be exact.  Which means this affects every page on the site, not just 
the bug form.

I apologize for pasting the patch in here like this, but I'm away from my normal 
machine, and it's not easy to upload an attachment from this machine.

Index: CGI.pl
===================================================================
RCS file: /cvsroot/mozilla/webtools/bugzilla/CGI.pl,v
retrieving revision 1.68
diff -u -r1.68 CGI.pl
--- CGI.pl      2000/08/21 19:50:41     1.68
+++ CGI.pl      2000/09/04 03:40:01
@@ -795,8 +795,6 @@
     print "  <TD VALIGN=CENTER ALIGN=LEFT>\n";
 
     print "$h2\n";
-    print "</TD></TR></TABLE>\n";
-
     print "</TD></TR></TABLE>\n";
 
     if (Param("shutdownhtml")) {
Assignee: tara → dave
Status: REOPENED → NEW
Summary: bug_form.pl has unbalanced <TABLE> tags → PutHeader has unbalanced <TABLE> tags
This has been checked in.
Status: NEW → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
Sorry for the spam, but I needed to be able to query for all of these correctly.
Target Milestone: --- → Bugzilla 2.12
VERIFIED.

Gerv
Status: RESOLVED → VERIFIED
Moving closed bugs to Bugzilla product
Component: Bugzilla → Bugzilla-General
Product: Webtools → Bugzilla
Version: other → unspecified
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.