Closed
Bug 438240
Opened 16 years ago
Closed 16 years ago
packager.mk does not mount image automatically
Categories
(Toolkit Graveyard :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: armenzg, Assigned: armenzg)
References
()
Details
(Whiteboard: hg patch missing)
Attachments
(2 files, 3 obsolete files)
3.81 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
7.56 KB,
application/octet-stream
|
Details |
When I run "make installers-foo" from browser/locales I reach the line: echo Y | hdiutil attach -readonly -mountroot /tmp -private -noautoopen $(UNPACKAGE) > hdi.output; which used to work to answer YES when questioned if we wanted to mount an image, BUT it doesn't not for me at least in Leopard (Axel says that he has the same problem on Tiger)
Assignee | ||
Comment 1•16 years ago
|
||
Putting it into toolokit/mozapps/installer might not be the best place to do so but will do for now
Assignee | ||
Comment 2•16 years ago
|
||
These couple of patches should not work right away since it worked for me by placing installdmg.ex in my home folder and I was calling it in packager.mk by ~/installercmg.ex I believe it didn't not work when I had it on toolkit/mozapps/installer, maybe something like $(PWD)/installdmg.ex might work ---------------- The regex matching now matches this: MOUNTPOINT=/tmp/Minefield instead of MOUNTPOINT=$'/tmp/Minefield\r' ---------------- Axel and Alice had to create their own scripts to be able to work around this confirmed bug.
Comment 3•16 years ago
|
||
You probably want $(srcdir)/installdmg.ex
Assignee | ||
Comment 4•16 years ago
|
||
I have seen hdi.output being generated under: $(srcdir)/dist/l10n-stage I will try both places - I will ask you for review when I have it working and I also tested it in previous versions of Mac OS X
Assignee | ||
Comment 5•16 years ago
|
||
Attachment #324367 -
Attachment is obsolete: true
Attachment #324372 -
Attachment is obsolete: true
Assignee | ||
Comment 6•16 years ago
|
||
I have finally tested it, I will attach script to see it working
Attachment #327687 -
Attachment is obsolete: true
Attachment #327827 -
Flags: review?(benjamin)
Assignee | ||
Comment 7•16 years ago
|
||
This script will not work right away when tonight we get the 3.0.2 en-US build on latest-mozilla1.9.0. You will have to modify the DMG_FILE and comment out the MOZ_CO_DATE
Assignee | ||
Updated•16 years ago
|
Attachment #327828 -
Attachment is patch: false
Attachment #327828 -
Attachment mime type: text/plain → application/octet-stream
Comment 8•16 years ago
|
||
Comment on attachment 327827 [details] [diff] [review] packager.mk + installerdmg.ex - It allows mounting on 10.5.x boy, I'd be so much happier if the entire packaging system were python. In the meantime, r=me (I presume we can rely on the presence of expect on mac systems...?)
Attachment #327827 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 9•16 years ago
|
||
(In reply to comment #8) > (I presume we can rely on the presence of expect on mac > systems...?) > In my mac came by default and alice has been using expect scripts for her talos machines Benjamin, does this patch require more reviews?
Assignee: nobody → armenzg
Assignee | ||
Updated•16 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•16 years ago
|
Whiteboard: hg patch missing
Assignee | ||
Comment 10•16 years ago
|
||
http://tinderbox.mozilla.org/showbuilds.cgi?tree=MozillaTry&maxdate=1218135177&legend=0&norules=1 I have used the try server but it won't be relevant since that part of the code is not used at all. I think it is used only for L10n repackages I will add the hg patch sometime between today and tomorrow
Comment 11•16 years ago
|
||
Pushed to mozilla-central, http://hg.mozilla.org/mozilla-central/index.cgi/rev/1c8dfe90f151
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•