Move Top 10 sorting out of the bookmark classes

RESOLVED FIXED in Camino2.0

Status

Camino Graveyard
Bookmarks
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Stuart Morgan, Assigned: Stuart Morgan)

Tracking

Trunk
Camino2.0
All
Mac OS X

Details

Attachments

(1 attachment)

fix
10.31 KB, patch
Mike Pinkerton (not reading bugmail)
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
Created attachment 324407 [details] [diff] [review]
fix

Another tiny step toward saner bookmark code. This moves the logic for how the top-10 list is actually decided out of the base bookmark classes, and into the top-10-managing class where it belongs (and re-expresses it in terms of sort descriptors). It also fixes a bug where the list may not be calculated correctly when two bookmarks have the same URL but different visit counts.

More sort cleanup will follow, but I want to keep the pieces small.
Attachment #324407 - Flags: superreview?(mikepinkerton)

Updated

10 years ago
Hardware: PC → All
Comment on attachment 324407 [details] [diff] [review]
fix

sr=pink
Attachment #324407 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Comment 2

10 years ago
Landed on trunk.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Camino2.0
You need to log in before you can comment on or make changes to this bug.