Closed Bug 438519 Opened 16 years ago Closed 16 years ago

DocumentType.internalSubset should be null, not "", when no internal subset

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dbaron, Assigned: roc)

References

()

Details

Attachments

(1 file)

DOM Level 3 core specifies that DocumentType.internalSubset should be null, not "", when there is no internal subset.  (This was ambiguous in DOM Level 2, where the property was introduced.)

This is tested in test 71 of Acid3.
Attached patch fixSplinter Review
I did this just for fun... Pretty easy.
Assignee: nobody → roc
Status: NEW → ASSIGNED
Attachment #324922 - Flags: superreview?(jonas)
Attachment #324922 - Flags: review?(jonas)
I wish we had VoidString(), like we have EmptyString()
roc, is your mochitest supposed to have a comment referencing bug 218236 in it?
No, that's just an oversight from when I copied the testcase to create this one.
Attachment #324922 - Flags: superreview?(jonas)
Attachment #324922 - Flags: superreview+
Attachment #324922 - Flags: review?(jonas)
Attachment #324922 - Flags: review+
Checked in
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Flags: in-testsuite+
Component: DOM: Core → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: