438585 - Updates to Public Suffix List

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Gervase Markham [:gerv]]

This bug covers the checkin of updates to the Public Suffix List submitted to [e-mail] by representatives of registries. Please contact me in case of any query.

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch A, v.1

Here's the first round of updates.

Gerv

Comment 2

[Gervase Markham [:gerv]]

Nominating for blocking; this update includes at least one fix for broken websites (.mx records were wrong; anyone with an example.mx domain can't set domain-wide cookies).

Gerv

Comment 3

[Gervase Markham [:gerv]]

Comment on attachment 326325 [details] [diff] [review]
Patch A, v.1

biesi is on vacation
bz is moving house
darin is not around
-> no netwerk peers.

shaver said he'd be happy with dwitte's review. Dan: can you oblige? It would be good to get this for 3.0.1 if at all possible.

Gerv

Comment 4

[[e-mail]]

Comment on attachment 326325 [details] [diff] [review]
Patch A, v.1

>+公司.cn
>+网络.cn
>+網絡.cn

since various people have had issues with utf8 patches/checkins in the past, please verify these appear properly after you land.

>+org.co
>+rec.co
>+web.co
>+
>+

extra newlines?

>+公司.hk
>+教育.hk
>+敎育.hk
>+政府.hk
>+個人.hk
>+个人.hk
>+箇人.hk
>+網络.hk
>+网络.hk
>+组織.hk
>+網絡.hk
>+网絡.hk
>+组织.hk
>+組織.hk
>+組织.hk 

same verification with these please.

> // nl : http://www.domain-registry.nl/ace.php/c,728,122,,,,Home.html
>+// Confirmed by registry <[e-mail]> (with technical
>+// reservations) 2008-06-08

curious; what were these reservations?

>diff --git a/netwerk/test/unit/test_bug414122.js b/netwerk/test/unit/test_bug414122.js
>--- a/netwerk/test/unit/test_bug414122.js
>+++ b/netwerk/test/unit/test_bug414122.js
>@@ -21,16 +21,17 @@ function run_test()
>+    line = line.replace(/^\s+/, "");

why are there lines with leading whitespace? if there are, they should be fixed, but if you need this then fine.

r=dwitte, ecstatic to see so many registries participating in the list... nice work!

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 326325 [details] [diff] [review]
Patch A, v.1

a=beltzner

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

reed/gavin, please check in and watch the UTF as dwitte warns!

Comment 7

[Reed Loden [:reed]]

Attachment: what I landed

This is what I landed.

Checking in netwerk/dns/src/effective_tld_names.dat;
/cvsroot/mozilla/netwerk/dns/src/effective_tld_names.dat,v  <--  effective_tld_names.dat
new revision: 1.5; previous revision: 1.4
done
Checking in netwerk/test/unit/test_bug414122.js;
/cvsroot/mozilla/netwerk/test/unit/test_bug414122.js,v  <--  test_bug414122.js
new revision: 1.2; previous revision: 1.1
done

Comment 8

[Gervase Markham [:gerv]]

Thanks :-) I got up just in time to do this, but it's nice not to have to rush :-)

Gerv

Comment 9

[(mostly gone) XtC4UaLL [:xtc4uall]]

is this going to land on trunk too?

Comment 10

[Gervase Markham [:gerv]]

Yep, when I get around to it :-)

Gerv

Comment 11

[Hasham]

Quick question about these suffix updates: were these suffix's unsupported before this patch? Or were there other problems like the .mx cookie issue brought up in comment 2? 

Comment 12

[Gervase Markham [:gerv]]

It depends what you mean by "supported". It was never true that Firefox didn't support a suffix, as in "refused to visit the site". What it did before is explained by the old state of the file; what it does now is explained by the new state :-)

In most cases, beforehand the policy was too loose, and it's now been tightened up. 

In the .mx case, it's the reverse. Also in this category are .co, .sb and .th, although no harm has been reported in these cases.

Gerv

Comment 13

[Hasham]

Ah, I see. Thanks, Gerv! BTW, is there any way to verify that these changes have been applied?

Comment 14

[Gervase Markham [:gerv]]

Do you mean, is there any way of telling that the version of Firefox you are running has the changes?

Here's one way, although it's a bit flaky. 

* Set the preference browser.identity.ssl_domain_display to 1. 
* Visit https://www.dgae-siae.unam.mx/

This is complicated by the fact that the site has some insecure content, and so the domain display disappears after a second or two, but if you briefly see "dgae-siae.unam.mx" then the patch hasn't been applied, and if you see "unam.mx" then it has.

Gerv

Comment 15

[Hasham]

Awesome, thanks Gerv! This is verified fixed on 1.9.0.1 based on testcase in comment 14.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.1) Gecko/2008070206 Firefox/3.0.1

Comment 16

[Myk Melez [:myk] [@mykmelez]]

Gerv checked in something from here (it's not clear what) today, then he backed it out when we were trying to figure out a test failure that started shortly after his checkin.

But his patch has now been cleared of culpability for the test failure and can land again when the tree reopens.

Comment 17

[Reed Loden [:reed]]

Pushed in 15880:c5a99dd3ae51.

Comment 18

[Gervase Markham [:gerv]]

Thank you, reed.

Gerv