Closed
Bug 438654
Opened 16 years ago
Closed 16 years ago
Set imap keywords for junk messages in manual junk analysis.
Categories
(MailNews Core :: Filters, defect)
MailNews Core
Filters
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.1a1
People
(Reporter: rkent, Assigned: rkent)
Details
Attachments
(1 file, 1 obsolete file)
6.78 KB,
patch
|
rkent
:
review+
rkent
:
superreview+
|
Details | Diff | Splinter Review |
Code for manually running the junk analyzer, such as the recently deforked junkCommands.js in bug 324953, does not set IMAP keywords after analysis. This will cause junk status to be lost when the folder database is "reindexed", or will prevent successful sharing of junk status with a shared IMAP folder.
Assignee | ||
Comment 1•16 years ago
|
||
I'm not sure what happens with a server that does not support custom keywords, but it seems to work fine on my server that supports them.
Attachment #328394 -
Flags: superreview?(bienvenu)
Attachment #328394 -
Flags: review?(bienvenu)
Comment 2•16 years ago
|
||
Comment on attachment 328394 [details] [diff] [review] storeCustomKeywords for junk status I know you just moved this code, but you don't need the temp var here, or the braces: + var copyService = Components.classes["@mozilla.org/messenger/messagecopyservice;1"] + .getService(Components.interfaces.nsIMsgCopyService); + copyService.CopyMessages(aFolder, aJunkMsgHdrs, actionParams.junkTargetFolder, true /* isMove */, null, + msgWindow, true /* allow undo */);
Attachment #328394 -
Flags: superreview?(bienvenu)
Attachment #328394 -
Flags: superreview+
Attachment #328394 -
Flags: review?(bienvenu)
Attachment #328394 -
Flags: review+
Assignee | ||
Comment 3•16 years ago
|
||
Carrying over reviews, patch to checkin.
Attachment #328394 -
Attachment is obsolete: true
Attachment #328543 -
Flags: superreview+
Attachment #328543 -
Flags: review+
Assignee | ||
Updated•16 years ago
|
Status: NEW → ASSIGNED
Keywords: checkin-needed
Comment 4•16 years ago
|
||
Checking in junkCommands.js; /cvsroot/mozilla/mailnews/base/resources/content/junkCommands.js,v <-- junkCommands.js new revision: 1.4; previous revision: 1.3 done
Updated•16 years ago
|
Attachment #328543 -
Attachment description: Fixed Bienvenu's nit → Fixed Bienvenu's nit (checked in)
Updated•16 years ago
|
Target Milestone: --- → mozilla1.9.1a1
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•