438867 - SVG not rendered due to <hr style="clear: both" />

Status: VERIFIED FIXED

(Core :: SVG, defect)

Description

[Christian Pekeler]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9) Gecko/2008061004 Firefox/3.0
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9) Gecko/2008061004 Firefox/3.0

This page contains SVG and SVG not rendered due to <hr style="clear: both" />. The style on the hr seems to break the SVG rendering. This page works fine in FF2 and Safari. I can reproduce the problem in FF3rc3 on mac and windows XP.

The svg is actually in the DOM (according to Firebug), it is just not rendered.


Reproducible: Always

Steps to Reproduce:
1. create some SVG with javascript
2. add <hr style="clear: both" /> to that page
3. load page in FF3rc3
Actual Results:  
only see the <hr>

Expected Results:  
see <hr> and the svg

SVG example code, to reproduce problem:

    var SVG_NS = "http://www.w3.org/2000/svg";
    var XLINK_NS = "http://www.w3.org/1999/xlink";
    var svgNode = document.createElementNS(SVG_NS, 'svg');
    svgNode.style.position = 'absolute';
    svgNode.style.left = '10px';
    svgNode.style.top = '10px';
    svgNode.style.zIndex = '2000000';
    document.body.appendChild(svgNode);
    var line = document.createElementNS(SVG_NS, "line");
    line.setAttribute('x1', '0');
    line.setAttribute('y1', '0');
    line.setAttribute('x2', '100');
    line.setAttribute('y2', '100');
    line.setAttribute('stroke', 'black');
    svgNode.appendChild(line);

only required body content:
    <hr style="clear: both" />

Comment 1

[James Seigel]

Hey, I also found that 

    <br clear=all>

in the body breaks this example.

Comment 2

[Christian Pekeler]

Another example, slightly different: http://pekeler.org/test/svg2.html

Comment 3

[Robert Longson [:longsonr]]

What happens if you use an xhtml rather than a html document?

Comment 4

[Christian Pekeler]

Same problem. See http://pekeler.org/test/svg.xhtml

Comment 5

[Ria Klaassen (not reading all bugmail)]

Regression range is http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1188491520&maxdate=1188493379
but only for http://pekeler.org/test/svg.html and http://pekeler.org/test/svg.xhtml
http://pekeler.org/test/svg2.html works also later.

Comment 6

[Robert Longson [:longsonr]]

Attachment: patch

Comment 7

[Robert Longson [:longsonr]]

Thanks for the regression range Ria, it really pinpointed what to look at.

Comment 8

[Robert Longson [:longsonr]]

Attachment: corrected patch

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 324931 [details] [diff] [review]
corrected patch

can you make a reftest?

Comment 10

[Robert Longson [:longsonr]]

Attachment: reftest

Comment 11

[Robert Longson [:longsonr]]

checked in.

Comment 13

[Samuel Sidler (old account; do not CC)]

Robert, does this patch apply to the 1.9 branch? I think we want this...

Comment 14

[Robert Longson [:longsonr]]

I'm pretty sure it would apply, yes.

Comment 15

[Samuel Sidler (old account; do not CC)]

Comment on attachment 324931 [details] [diff] [review]
corrected patch

Approved for 1.9.0.2. Please land in CVS. a=ss

Be sure to land the reftest as well.

Comment 16

[Marcia Knous [:marcia]]

verified fixed on the 1.9.0 branch using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.2pre) Gecko/2008082004 GranParadiso/3.0.2pre. I verified using the test case in the URL.

verified fixed on the trunk using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1a2pre) Gecko/20080820020636 Minefield/3.1a2pre.