43887 - Mozilla will not compile on Win2k

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Jerry Baker]

Following these exact steps, Mozilla will not build on Windows 2000 Professional 
using MS Visual Studio 6.0 SP3.

1. Delete *EVERYTHING* in %MOZ_SRC% so that you will have an absolutely clean 
tree. Reproducing this bug will be impossible without a virgin tree.

2. Download the Mozilla source tar ball.

3. Extract it to %MOZ_SRC%.

4. Run "nmake /f client.mak build_all"

Result: Mozilla build fails with the following error

----------
Microsoft (R) Library Manager Version 6.00.8447
Copyright (C) Microsoft Corp 1992-1998. All rights reserved.

-NOLOGO -OUT:WIN32_O.OBJ\exthandlers_s.lib
.\WIN32_O.OBJ\nsExternalHelperAppService.obj 
.\win\WIN32_O.OBJ\nsOSHelperAppService.obj
LIB : fatal error LNK1181: cannot open input file
".\win\WIN32_O.OBJ\nsOSHelperAppService.obj"
NMAKE : fatal error U1077: 'lib' : return code '0x49d'
Stop.
----------

Expected: Mozilla should compile.

This has been going on since last week. After two postings about it that went 
unanswered in n.p.m.builds, I filed here. The problem is that nothing under 
mozilla/uriloader/exthandler/win is getting built at all. If you manually build 
mozilla/uriloader/exthandler/win/makefile.win before you try to compile Mozilla, 
it will build fine.

I looked in Bonsai for changes to the makefile and mscott has a checkin that 
occured right before I couldn't build anymore. His comments suggest that this is 
not supposed to be part of the build, yet Link is looking for it...why???

Comment 1

[cls]

Bouncing to mscott.  I don't have a windows build but something looks funny. 
exthandler/uriloader/makefile.win has 2 includes to config.mak, one of which is
obviously wrong.  What does Win2k set WINOS to?


MODULE = exthandler

DIRS=win

DEPTH = ..\..
include <$(DEPTH)/config/config.mak>

include <$(DEPTH)\config\config.mak>

Comment 2

[Jerry Baker]

I have WINOS and OS_TARGET set to WIN95.

Comment 3

[Jerry Baker]

BTW. The version of mozilla/uriloader/makefile.win does not have two includes. 
It only has the one as "include <$(DEPTH)\config\rules.mak>".

Comment 4

[Scott MacGregor]

are you saying that on your win2k build the compiler is not entering the win
directory even though the makefile.win in uriloader\exthandler says:
DIRS=win


Hmm I'm not sure why W2K would be different than the regular windows build.

By the way, this was turned on Thursday night before midnight so you should have
started to see the problem then (which it sounds like you were).

Comment 5

[Jerry Baker]

Right. Nothing in that directory gets built unless I go do it manually.

Comment 6

[Jerry Baker]

This might help. I found this line right above the error. It looks like 
Mozilla's build system is refusing to build it because of the target

w95make: Entering Directory D:\mozilla_src\mozilla\uriloader\exthandler\win with
 target libs
The libs build phase is obsolete.

Comment 7

[Jerry Baker]

Here's what I have so far:

If I change mozilla/uriloader/exthandler/makefile.win so that all it says:

----------
MODULE=exthandler

DIRS=win
DEPTH = ..\..

include <$(DEPTH)\config\config.mak>
-----------

It still does not build anything in the win directory. I am stumped. If I run 
the makefile.win in the win directory manually it works, but if I run the above 
makefile, it does not build.

I even made a new makefile that contained one line: "DIRS=win". It still does 
nothing when I run that.

Comment 8

[Jerry Baker]

If I remove line #47 from mozilla/uriloader/exthandler/makefile.win everything 
builds fine. I don't know what is going on, but that fixes it for me.

Comment 9

[Jerry Baker]

It compiles from mozilla/uriloader/exthandler/makefile.win, but building Mozilla 
fails because of unresolved external symbols. I give up :(

Comment 10

[Jerry Baker]

Any progress? This is making automated builds of Mozilla impossible here.

Comment 11

[Scott MacGregor]

JerryI dont have a windows 2000 box. Can you test this patch? apply it in
uriloader and let me know if it fixes your problem.

Comment 12

[Scott MacGregor]

Attachment: possible makefile fix

Comment 13

[Jerry Baker]

Works here

Comment 14

[Scott MacGregor]

Fix checked in. It didn't have a nsbeta2+ yet but I was fixing build breakage on
win2k machines so it should be okay in this case.

Thanks for veryifying the fix jerry.

Comment 15

[Jerry Baker]

No, thank you for fixing it. Now how about getting someone on bug 43901 :)

Comment 16

[Jon Granrose]

I'm trying to verify this bug.  I see the first patch checked in as version 1.4,
but don't see the last patch that is attached to this bug checked in anywhere.

However, since Jerry says this is working for him now, marking verified.

Comment 17

[Jerry Baker]

MSCott's 1.6 checkin to mozilla/uriloader/makefile.win is what fixed it 
apparently.

Comment 18

[Jerry Baker]

Mass removing self from CC list.

Comment 19

[Jerry Baker]

Now I feel sumb because I have to add back. Sorry for the spam.