438879 - Bad encoding in the Download Day Certificate PDF

Status: VERIFIED FIXED

(Webtools Graveyard :: Download Day, defect, P1)

Description

[Staś Małolepszy :stas]

1. the ribbon that says "Thank you". It should be "DZIĘKUJEMY!" (the image is missing the "Ę")

2. these are the Polish letters I used as my name: ą ć ę ó ł ń ź ż ś. Only ó is displayed.

Can we fix this, please?

Comment 1

[Ryan Doherty (:rdoherty)]

I can take care of the ribbon. Chris, can you check on the missing characters?

Comment 2

[Chris Pollett]

Okay to set FPDF to do this I need True Type Font for ISO 8859-2. (prefereably free). I was having some difficulty finding such fonts, mainly because of my own cluelessness. I came across the following site:
http://www.sweb.cz/ls78/ttfonts.htm
which has the kind of fonts we need, but it doesn't seem to mention any licensing or anything. So if people have better suggestions left me know. I will probably go ahead and generate some FPDF font from these and then replace with something better when I am told about it.

Comment 3

[Staś Małolepszy :stas]

I know that e.g. Helvatica or Times work fine with Polish characters, but I'm not sure about the legal issues.

How about this page: http://www.slovo.info/unifonts.htm 
It mainly provides links to MS Corefonts downloads. Are corefonts ok here? :/

Comment 4

[Ryan Doherty (:rdoherty)]

Hey Chris, let's go ahead with what you found for now. 

Comment 5

[Chris Pollett]

Attachment: patch to handle polish

I got the fonts from:
http://nl.ijs.si/gnusl/cee/iso8859-2.html
scroll to MS Windows 3.x used the one called latin2.zip.
Uploading needed binary file as separate attachment

Comment 6

[Chris Pollett]

Attachment: lib/fpdf/font/central-european.z binary file needed to get previous patch to work

Comment 7

[Ryan Doherty (:rdoherty)]

Comment on attachment 325270 [details] [diff] [review]
patch to handle polish

Works! Thanks Chris!

Comment 8

[Chris Pollett]

checked in r15807

Comment 9

[Staś Małolepszy :stas]

Yay! It works, thank you guys!

I used the Certificate generator at
https://spreadfirefox.authstage.mozilla.com/pl/worldrecord/certificate_form?state=post

and it looks great, as you can see in the screenshot here:
http://informationisart.com/stas/screenshots/Preview-20080617-020821.jpg

However, when I try to type in some Western letters (still on the Polish version of the site), like à or è, it gives me question marks. I don't think this is a serious issue (these letters don't exist in Polish), but maybe a fix is a quick one. If not, let's leave it as it is, it's already a great improvement. Thanks again.

Comment 10

[Ryan Doherty (:rdoherty)]

(In reply to comment #9)

> However, when I try to type in some Western letters (still on the Polish
> version of the site), like à or è, it gives me question marks. I don't think
> this is a serious issue (these letters don't exist in Polish), but maybe a fix
> is a quick one. If not, let's leave it as it is, it's already a great
> improvement. Thanks again.
> 

We should probably leave this as is. The odds of someone entering  à or è is pretty small.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED per comment 9.