Closed Bug 439035 Opened 12 years ago Closed 12 years ago
Same-origin check in ns
XMLHttp Request::On Channel Redirect() can be circumvented
This is fx2-only. (On trunk, the same-origin check in question compares an old URI to a new URI.) The same-origin check in nsXMLHttpRequest::OnChannelRedirect() uses a principal of an associated JS context. It can be circumvented by loading a cross-origin page in that context before nsXMLHttpRequest::OnChannelRedirect() is called. By using this trick, an attacker can read contents and http headers of a target site. Upcoming testcase consists of an html and a cgi script, thus it does not work on bugzilla.mozilla.org. Please set up it in a suitable place.
Jonas, any reason not to just make fx2 do what trunk does here? I.e. just compare the URIs and not bother using the unreliable context pointer here?
Yup, that's what we should do
Assignee: nobody → jonas
Jonas can you work up the patch?
This fixes this bug, verified with local install of the testcase.
Comment on attachment 325799 [details] [diff] [review] Fix per above comments. Not sure if we've decided to take more changes for 188.8.131.52, but if we did this would be a good candidate.
Comment on attachment 325799 [details] [diff] [review] Fix per above comments. Approved for 184.108.40.206 and 220.127.116.11, a=dveditz for release-drivers Please land on both branches (MOZILLA_1_8_BRANCH for 18.104.22.168 and GECKO181_20080612_RELBRANCH for 22.214.171.124) and give the bug both fixed126.96.36.199 and fixed188.8.131.52 keywords
Fix landed on both branches.
Verified the bug with Firefox 184.108.40.206 and the fix with the final 220.127.116.11 build (Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:18.104.22.168) Gecko/2008062305 Firefox/22.214.171.124).
I've verified this, again, with : Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:126.96.36.199) Gecko/2008070205 Firefox/188.8.131.52. With 184.108.40.206, I get the data from mozilla.com in great detail. This does not happen in 220.127.116.11.
Comment on attachment 325799 [details] [diff] [review] Fix per above comments. This patch had approval for 18.104.22.168, but apparently the flags got moved out. Clearing that flag to clear the queries.
Attachment #325799 - Flags: approval22.214.171.124+
You need to log in before you can comment on or make changes to this bug.