43911 - Double clicking on message in search window won't open it in a standalone window

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[scottputterman]

If you use mail search, when you get the results, you can't double click on a 
message to open it in a standalone message window.

Comment 1

[scottputterman]

nominating for nsbeta2. One of the main ways people use search is to get the 
results and then view a message by double clicking on it. This is pretty 
important to using the feature.

Comment 2

[Jay Patel [:jay]]

Putting on [NEED INFO] radar.  Can we view the message in any other way from the 
search dialog?

Comment 3

[laurel]

I'm not sure how putterm even got a search to work, I certainly can't yet (can't
set criteria).

For [NEED INFO]: No, not any other way to view the message at this point in time
(even if search worked). User would have to search, look at the results, then
manually go hunt the message down in it's actual folder location.  (Note: in
addition, there is an OPEN button planned to provide same functionality of
opening to message window.)

I vote beta2 for this.

Comment 4

[Alec Flett]

Actually, he never got it to work, but I know that I have not written that yet,
so this bug was the result of he and I talking about the one last feature.

Search is still totally busted right now due to XBL issues.

Comment 5

[Alec Flett]

Attachment: proposed fix

Comment 6

[Alec Flett]

Thanks to a temporary patch from hyatt, I was able to get search working on my 
local tree.. then I was able to implement this.

Scott, do you mind reviewing? Basically
- I moved a bunch of functions around
- I abstracted the folder datasource into GetFolderDatasource, which is 
implemented differently in the 3-pane vs. the search window
- I changed how we get the source folder for a message (a few months ago, I had 
implemented the msgFolder attribute on messages) instead of relying on the 
loaded message in the message pane.

Comment 7

[Jay Patel [:jay]]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 8

[Alec Flett]

I have tested my fix, putterman has reviewed. Will go in today

Comment 9

[Alec Flett]

fix checked in.

Comment 10

[laurel]

OK using jun30 m17 commercial build, linux rh6.0, NT 4.0 and Mac OS 9.0