Selecting events in the unifinder doesn't scroll view to event

VERIFIED FIXED in 0.9

Status

Calendar
Calendar Views
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

unspecified

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 325109 [details] [diff] [review]
Center selected events - v1

Small annoyance I've often encountered: When you click on an event in the unifinder, you usually have to also scroll to the event after clicking.

This patch takes care by attempting to show as many selected events as possible in the view when something is selected in the unifinder. If one event is clicked, it is centered. If a second event is added to the selection and it is close enough to the first event, both events will be shown in the view.

Looking at the selection code in calendar-multiday-view almost made me rewrite it, we should do something to fix that...
Attachment #325109 - Flags: review?(Berend.Cornelius)

Comment 1

10 years ago
Comment on attachment 325109 [details] [diff] [review]
Center selected events - v1

>   * Make as many of the selected items as possible are visible in the view.
>   */
>  void centertSelectedItems();
>  /**

orthographical mistake!

For the rest the patch works as advertised and looks good.
Attachment #325109 - Flags: review?(Berend.Cornelius) → review+
(Assignee)

Comment 2

10 years ago
Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.9

Comment 3

10 years ago
Checked in lightning 2008061918 and Sunbird 20080619 -> VERIFIED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.