439347 - Applications preference list empty when gnome libraries are not installed

Status: RESOLVED DUPLICATE of bug 409192

(Firefox :: Settings UI, defect)

Description

[Mike Hommey [:glandium]]

Attachment: patch

When the gnome libraries are not installed on the user system, the shell service module can't be loaded, which means all the code that is #ifdef'ed on HAVE_SHELL_SERVICE is likely to fail.
This makes the applications preference pane initialization code fail, because it gets an exception when intializating gApplicationPane members.
The attached patch solves the issue by using getShellService() defined in utilityOverlay.js, which fails gracefully.

It could be worth checking all places where HAVE_SHELL_SERVICE is ifdef'ed to see if runtime failure handling is required.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 325191 [details] [diff] [review]
patch

Can you update the comments in the try/catches that surround the uses of this property to also mention that shellSvc is potentially null?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Please post the updated patch in bug 409192.