Closed
Bug 439347
Opened 17 years ago
Closed 17 years ago
Applications preference list empty when gnome libraries are not installed
Categories
(Firefox :: Settings UI, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 409192
People
(Reporter: glandium, Unassigned)
Details
Attachments
(1 file)
474 bytes,
patch
|
Details | Diff | Splinter Review |
When the gnome libraries are not installed on the user system, the shell service module can't be loaded, which means all the code that is #ifdef'ed on HAVE_SHELL_SERVICE is likely to fail.
This makes the applications preference pane initialization code fail, because it gets an exception when intializating gApplicationPane members.
The attached patch solves the issue by using getShellService() defined in utilityOverlay.js, which fails gracefully.
It could be worth checking all places where HAVE_SHELL_SERVICE is ifdef'ed to see if runtime failure handling is required.
Attachment #325191 -
Flags: review?(gavin.sharp)
Comment 1•17 years ago
|
||
Comment on attachment 325191 [details] [diff] [review]
patch
Can you update the comments in the try/catches that surround the uses of this property to also mention that shellSvc is potentially null?
Attachment #325191 -
Flags: review?(gavin.sharp)
Comment 2•17 years ago
|
||
Please post the updated patch in bug 409192.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•