Its possible to attempt to delete mailing lists from OS X Address book via TB

VERIFIED FIXED in mozilla1.9

Status

--
major
VERIFIED FIXED
11 years ago
11 years ago

People

(Reporter: hwaara, Assigned: standard8)

Tracking

Trunk
mozilla1.9
All
Mac OS X
Bug Flags:
wanted-thunderbird3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
If I select a mailing list (which is from the OS X address book) and click the delete button, it doesn't work and I get this:

An error occurred executing the button_delete command
[Exception... "Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIAbManager.deleteAddressBook]"  nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)"  location: "JS frame :: chrome://messenger/content/addressbook/abCommon.js :: AbDeleteDirectory :: line 334"  data: no]
(Assignee)

Comment 1

11 years ago
The problem here is that we're not disabling the relevant button if the address book is read-only.
Flags: wanted-thunderbird3+
Summary: Cannot delete (OS X address book) mailing list from TB → Its possible to attempt to delete mailing lists from OS X Address book via TB
(Assignee)

Comment 2

11 years ago
Created attachment 325310 [details] [diff] [review]
The fix

Here's the fix, quite easy as it turned out, when checking cmd_delete or button_delete just ensure the directory does or doesn't have the opWrite flag set.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #325310 - Flags: superreview?(bienvenu)
Attachment #325310 - Flags: review?(bienvenu)

Updated

11 years ago
Attachment #325310 - Flags: superreview?(bienvenu)
Attachment #325310 - Flags: superreview+
Attachment #325310 - Flags: review?(bienvenu)
Attachment #325310 - Flags: review+
(Assignee)

Comment 3

11 years ago
Checked in -> fixed. For testers, ensure that Mac Mailing lists don't have the delete option available, and that the delete option remains available on address books (apart from PAB & CAB) and other types of mailing lists.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.2pre) Gecko/2008070703 Thunderbird/3.0a2pre ID:2008070703
Status: RESOLVED → VERIFIED
Hardware: PC → All
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.