439647 - ByteArray not write indexable

Status: VERIFIED WORKSFORME

(Tamarin Graveyard :: Virtual Machine, enhancement)

Description

[Pär Winzell]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0
Build Identifier: hg rev 583

Running this:

  var arr :ByteArray = new ByteArray();
  arr[0] = 1;

yields a kWriteSealedError, "Cannot create property 0 on arr".

Reproducible: Always

Steps to Reproduce:
1. Compile the tiny script above.
2. $AVMSHELL -Dinterp script.abc
3. fail to profit



Adding this to ByteArrayGlue.cpp seems to fix the problem, but I'm too green to know if it's the proper approach:

    void ByteArrayObject::setMultinameProperty(Multiname* name, Atom value)
    {
        if (isValidDynamicName(name)) {
            setStringProperty(name->getName(), value);
        } else {
            ScriptObject::setMultinameProperty(name, value);
        }
    }

i.e. skip the 'is dynamic' check.

Comment 1

[Lars T Hansen]

Seems like a good idea.

Comment 2

[Brent Baker]

This appears to be possible in the latest TC. Following the above steps does run properly.