439713 - add-ons window after restore killed session with "newly installed" items shows all buttons (install, install updates, show information, hide information, find updates, contin)

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[timeless]

Attachment: picture showing offscreen buttons

Build identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0

steps:
1. download firefox on firefox download day
2. download http://forum.addonsmirror.net/ext/extensions/C/ChatZilla/ChatZilla_0.9.78.1.xpi
3. download http://forum.addonsmirror.net/ext/extensions/J/JavaScript_Debugger/JavaScript_Debugger_(Venkman)_0.9.87.xpi
(i think i actually installed venkman.xpi, but it doesn't seem to care)
4. load about:config
5. reset each of:
app.update.auto
app.update.enabled
app.update.lastUpdateTime.addon-background-update-timer
app.update.lastUpdateTime.background-update-timer
app.update.lastUpdateTime.blocklist-background-update-timer
app.update.lastUpdateTime.microsummary-generator-update-timer
app.update.lastUpdateTime.restart-nag-timer
app.update.lastUpdateTime.search-engine-update-timer
6. set to true:
javascript.options.showInConsole
7. use file>open to open the two xpis
8. click install now for each
9. use task manager to go to process for firefox
10. use delete to kill the process
11. run firefox
12. (choose the profile you're using)
13. chose restore process

well, it should be something like that. the restore bit is definitely necessary.

i'm able to reproduce it with this profile, i'll try to send it to mossop

actual results:
Error: item is null
Source File: chrome://mozapps/content/extensions/extensions.js
Line: 1099

+ picture

Comment 1

[timeless]

Attachment: profile

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Can be seen on all platforms. See my comment in bug 419929 comment 20 for more information of the same issue.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Jeff, I think we should dupe this bug against bug 467747.

Comment 4

[Tony Chung [:tchung]]

I hit this today on 1.9.2 nightly running on mac.  

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b1pre) Gecko/20090923 Namoroka/3.6b1pre

Screenshot: http://www.grabup.com/uploads/45b2129475432bf78393145af517a082.png

Comment 5

[Tony Chung [:tchung]]

These are the errors thrown when i open addons manager with the blank data as shown in the bug.  

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIRDFService.GetLiteral]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://mozapps/content/extensions/extensions.js :: rebuildLWThemeDS :: line 873"  data: no]

Clicking the "Skip" button fires this error:

Error: uncaught exception: [Exception... "'JavaScript component threw a null value as an exception' when calling method: [nsIExtensionManager::removeInstallListenerAt]"  nsresult: "0x8057001d (NS_ERROR_XPC_JS_THREW_NULL)"  location: "JS frame :: chrome://mozapps/content/extensions/extensions.js :: Shutdown :: line 1319"  data: no]

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

(In reply to comment #5)

> Error: uncaught exception: [Exception... "Component returned failure code:
> 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIRDFService.GetLiteral]"  nsresult:
> "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame ::
> chrome://mozapps/content/extensions/extensions.js :: rebuildLWThemeDS :: line
> 873"  data: no]

That sounds like another issue with the recently landed lightwight themes code. Or on the other side it makes this bug more obvious.

Comment 7

[Tony Chung [:tchung]]

(In reply to comment #6)
> (In reply to comment #5)
> 
> > Error: uncaught exception: [Exception... "Component returned failure code:
> > 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIRDFService.GetLiteral]"  nsresult:
> > "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame ::
> > chrome://mozapps/content/extensions/extensions.js :: rebuildLWThemeDS :: line
> > 873"  data: no]
> 
> That sounds like another issue with the recently landed lightwight themes code.
> Or on the other side it makes this bug more obvious.

yes, this was my hunch, that it is related to mossop's checkin on 9/22: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/e5a3d46e380b.   Still investigating before opening a new bug.   Mossop, any thoughts in the meantime?

Comment 8

[Dave Townsend [:mossop]]

(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > 
> > > Error: uncaught exception: [Exception... "Component returned failure code:
> > > 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIRDFService.GetLiteral]"  nsresult:
> > > "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame ::
> > > chrome://mozapps/content/extensions/extensions.js :: rebuildLWThemeDS :: line
> > > 873"  data: no]
> > 
> > That sounds like another issue with the recently landed lightwight themes code.
> > Or on the other side it makes this bug more obvious.
> 
> yes, this was my hunch, that it is related to mossop's checkin on 9/22:
> http://hg.mozilla.org/releases/mozilla-1.9.2/rev/e5a3d46e380b.   Still
> investigating before opening a new bug.   Mossop, any thoughts in the meantime?

Yeah you're hitting something different, most likely due to the hacky way we're installing lightweight themes right now. If you don't include a name in the js you execute then it will break like this. The install service ensures that a name is present.

Comment 9

[Blair McBride [:Unfocused] (UNAVAILABLE)]

This was originally reported before the Add-ons Manager was rewritten, and there have been no recent reports of similar behaviour with the new Add-ons Manager. If you encounter this bug in the new Add-ons Manager, please file a new bug with fresh information.