439722 - Make the "bad cert error dialog" more helpful

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Kai Engert (:KaiE:)]

The "bad cert error dialog" is currently not allowing to display the cert, and it provides less information than the error page in firefox.

I have a patch to improve that a bit.

(This also prepares for further additions to the dialog, should we ever consider to add a way to add exceptions from here... Which seems unlikely right now...)

Comment 1

[Kai Engert (:KaiE:)]

Attachment: What we have today

Comment 2

[Kai Engert (:KaiE:)]

Attachment: What I propose

Comment 3

[Kai Engert (:KaiE:)]

Attachment: Patch v1

Comment 4

[Robert Relyea]

Comment on attachment 325449 [details] [diff] [review]
Patch v1

r+ for the dialog (based on the screen shots).

this is not a review of the correctness of the code.

Comment 5

[Kai Engert (:KaiE:)]

Comment on attachment 325449 [details] [diff] [review]
Patch v1

Hi Dan and/or Johanthan, would you be able to have a look at the UI code I'm adding, which bob isn't comfortable reviewing?

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 325449 [details] [diff] [review]
Patch v1

>+<!ENTITY certErrorDlg.info1 "This could be a problem with the server's configuration, or it could be someone trying to impersonate the server.">
>+<!ENTITY certErrorDlg.info2 "If you have connected to this server successfully in the past, the error may be temporary, and you can try again later.">

ObNit: delete both commas in .info2. I don't think info1 needed its comma either but it bothers me less.

sr=dveditz

Comment 7

[Kai Engert (:KaiE:)]

Attachment: Patch v2

Removed the commas as suggested by Dan.
Also fixed an IDL comment block.

Carrying forward reviews.

Comment 8

[Kai Engert (:KaiE:)]

checked in, marking fixed
5b74dbcd42f5