Closed
Bug 439910
Opened 18 years ago
Closed 18 years ago
No glyph info set for low surrogates
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: smontagu, Unassigned)
Details
Attachments
(2 files)
|
1.16 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
|
1.16 KB,
text/html
|
Details |
In Pango Cairo we are just passing over low surrogates in SetupClusterBoundaries and not setting any value in mCharacterGlyphs.
I can't provide a testcase because I don't know any case that fails in current code, but I encountered this when trying to add surrogate support to FindFirstLetterRange, so there will eventually be reftests from bug 399941 to cover it.
| Reporter | ||
Comment 1•18 years ago
|
||
Attachment #325524 -
Flags: superreview?(roc)
Attachment #325524 -
Flags: review?(roc)
| Reporter | ||
Comment 2•18 years ago
|
||
OK, here's a testcase that shows that non-BMP characters are getting double letter-spacing applied.
Comment on attachment 325524 [details] [diff] [review]
Patch
great
Attachment #325524 -
Flags: superreview?(roc)
Attachment #325524 -
Flags: superreview+
Attachment #325524 -
Flags: review?(roc)
Attachment #325524 -
Flags: review+
Can you make that testcase into a reftest? You probably can by wrapping the non-BMP characters in spans with padding instead of using letter-spacing.
| Reporter | ||
Comment 5•18 years ago
|
||
Thanks for the suggestion, that was a lot simpler than my own idea for a reftest. Patch and reftest checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•