Closed Bug 439910 Opened 18 years ago Closed 18 years ago

No glyph info set for low surrogates

Categories

(Core :: Graphics, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: smontagu, Unassigned)

Details

Attachments

(2 files)

In Pango Cairo we are just passing over low surrogates in SetupClusterBoundaries and not setting any value in mCharacterGlyphs. I can't provide a testcase because I don't know any case that fails in current code, but I encountered this when trying to add surrogate support to FindFirstLetterRange, so there will eventually be reftests from bug 399941 to cover it.
Attached patch Patch — — Splinter Review
Attachment #325524 - Flags: superreview?(roc)
Attachment #325524 - Flags: review?(roc)
Attached file Testcase —
OK, here's a testcase that shows that non-BMP characters are getting double letter-spacing applied.
Attachment #325524 - Flags: superreview?(roc)
Attachment #325524 - Flags: superreview+
Attachment #325524 - Flags: review?(roc)
Attachment #325524 - Flags: review+
Can you make that testcase into a reftest? You probably can by wrapping the non-BMP characters in spans with padding instead of using letter-spacing.
Thanks for the suggestion, that was a lot simpler than my own idea for a reftest. Patch and reftest checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: