[FIX]Javascript-based form for posting is not showing up the way that it should

RESOLVED FIXED

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: thompux, Assigned: bzbarsky)

Tracking

({regression})

Trunk
x86
Windows XP
regression
Points:
---
Dependency tree / graph
Bug Flags:
wanted1.9.1 +
blocking1.9.0.1 -
wanted1.9.0.x +
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0

When I go to post a new topic on the forum the form that I use, which has options for making text bold, italics, to create hyperlinks, etc. will not show up in my browser. I am thinking that it is an issue with how Firefox 3 is rendering Javascript on this particular page.

Reproducible: Always

Steps to Reproduce:
1. Go to http://www.websitetoolbox.com/tool/mb/titanscentral
2. Must register a username to post
3. After username registration, go to any one of the forums and click on "New Post" 
Actual Results:  
The menu strip will not render at all.

Expected Results:  
The menu strip should be underneath "* Message".

This was an issue before when Firefox 2 was released, and it eventually got fixed after I sent the bug in for inspection, but now it's an issue again.
(Reporter)

Comment 1

10 years ago
!EDIT!

You DO NOT have to register a username to reproduce this bug. My apologies. Simply go to the URL in the first step, go into any given forum, and click on the "New Post" button.
Regression range for this is http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1193961900&maxdate=1193964899
-> Bug 389350.
Blocks: 389350
Status: UNCONFIRMED → NEW
Component: General → Editor
Ever confirmed: true
Keywords: regression
Product: Firefox → Core
QA Contact: general → editor
Version: unspecified → Trunk
Flags: blocking1.9.1?
Flags: blocking1.9.0.1?
This is the offending code:
function startEditor(myTextarea){
oTextarea=myTextarea;
try{document.getElementById('divEditorMask').style.display="";
htmlFrame=document.getElementById('edit');
htmlWindow=htmlFrame.contentWindow;
htmlEditor=htmlWindow.document;htmlEditor.designMode="on";
htmlEditor.execCommand("undo",false,null);}
catch(e){
document.getElementById('divEditorMask').style.display="none";return;
}

When I remove the htmlEditor.execCommand("undo",false,null); code, then the rich editor shows up fine.

Updated

10 years ago
Blocks: 424615
Flags: wanted1.9.0.x?
Flags: blocking1.9.0.1?
Flags: blocking1.9.0.1-
Flags: blocking1.9.1? → wanted1.9.1+
Flags: wanted1.9.0.x? → wanted1.9.0.x+
Created attachment 342461 [details] [diff] [review]
Fix

This does the trick
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #342461 - Flags: superreview?(peterv)
Attachment #342461 - Flags: review?(peterv)
Summary: Javascript-based form for posting is not showing up the way that it should → [FIX]Javascript-based form for posting is not showing up the way that it should
Attachment #342461 - Flags: superreview?(peterv)
Attachment #342461 - Flags: superreview+
Attachment #342461 - Flags: review?(peterv)
Attachment #342461 - Flags: review+
Comment on attachment 342461 [details] [diff] [review]
Fix

Maybe name it IsEditingOnAfterFlush? Don't like it much, but don't really like TryEditingOn either :-/.
Pushed changeset 84ae8ab37bca with the IsEditingOnAfterFlush().  I can't think of a better name.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.