439965 - [FIX]Javascript-based form for posting is not showing up the way that it should

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[thompux]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0

When I go to post a new topic on the forum the form that I use, which has options for making text bold, italics, to create hyperlinks, etc. will not show up in my browser. I am thinking that it is an issue with how Firefox 3 is rendering Javascript on this particular page.

Reproducible: Always

Steps to Reproduce:
1. Go to http://www.websitetoolbox.com/tool/mb/titanscentral
2. Must register a username to post
3. After username registration, go to any one of the forums and click on "New Post" 
Actual Results:  
The menu strip will not render at all.

Expected Results:  
The menu strip should be underneath "* Message".

This was an issue before when Firefox 2 was released, and it eventually got fixed after I sent the bug in for inspection, but now it's an issue again.

Comment 1

[thompux]

!EDIT!

You DO NOT have to register a username to reproduce this bug. My apologies. Simply go to the URL in the first step, go into any given forum, and click on the "New Post" button.

Comment 2

[Ria Klaassen (not reading all bugmail)]

Regression range for this is http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1193961900&maxdate=1193964899
-> Bug 389350.

Comment 3

[Martijn Wargers (dead)]

This is the offending code:
function startEditor(myTextarea){
oTextarea=myTextarea;
try{document.getElementById('divEditorMask').style.display="";
htmlFrame=document.getElementById('edit');
htmlWindow=htmlFrame.contentWindow;
htmlEditor=htmlWindow.document;htmlEditor.designMode="on";
htmlEditor.execCommand("undo",false,null);}
catch(e){
document.getElementById('divEditorMask').style.display="none";return;
}

When I remove the htmlEditor.execCommand("undo",false,null); code, then the rich editor shows up fine.

Comment 4

[Martijn Wargers (dead)]

Attachment: testcase

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

This does the trick

Comment 6

[Peter Van der Beken [:peterv]]

Comment on attachment 342461 [details] [diff] [review]
Fix

Maybe name it IsEditingOnAfterFlush? Don't like it much, but don't really like TryEditingOn either :-/.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Pushed changeset 84ae8ab37bca with the IsEditingOnAfterFlush().  I can't think of a better name.