440063 - Tor Button breaks Foxmarks

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Todd Agulnick]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0

STR:

- Install Foxmarks
- Install Tor Button extension
- Attempt to sync with Foxmarks

Result:

[Exception... "Illegal operation on WrappedNative prototype object"  nsresult: "0x8057000c (NS_ERROR_XPC_BAD_OP_ON_WN_PROTO)"  location: "JS frame :: chrome://foxmarks/content/foxmarks-places.js :: Call :: line 101"  data: no]

when calling nsINavHistoryService.getNewQueryOptions().

I've spoken offline with the developer of Tor Button but Polvi suggested I open this here, too, so here it is.

Comment 1

[Carl]

I have the same problem.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0
TorButton 1.20rc1
FoxMarks 2.0.47.4

My console shows:

Error: [Exception... "'Error: Places error calling function getNewQueryOptions() {
    [native code]
} with args [] Original error: [Exception... "Illegal operation on WrappedNative prototype object"  nsresult: "0x8057000c (NS_ERROR_XPC_BAD_OP_ON_WN_PROTO)"  location: "JS frame :: chrome://foxmarks/content/foxmarks-places.js :: Call :: line 101"  data: no]' when calling method: [nsIStreamLoaderObserver::onStreamComplete]"  nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)"  location: "<unknown>"  data: no]

Comment 2

[Jeff]

I had this issue as well.  The stated workaround was to disable the TOR button.  I did that but still could not sync.  After I uninstalled TOR I was then able to sync my bookmarks without any problems.

Comment 3

[Chris Hasbrouck]

Just wanted to confirm Jeff's post above.  I too require un-installing Tor Button for my Foxmarks synchronization to work.

Comment 4

[Mike Perry]

I've diagnosed this issue down to a function call wrapper that Foxmarks has for performance measurements. The problem is they were calling object method calls with apply and a null 'this' argument, instead of passing in an appropriate this pointer, which probably runs afoul of more stricter javascript context checking in firefox 3. The foxmarks author said he would fix the issue on their end. I imagine this probably shouldn't be a firefox bug, but I don't have the authority to close it.

Comment 5

[Mike Fiorella]

I was able to get Foxmarks to work by simply Disabling TOR Button.  I did not have to completely uninstall it.

Comment 6

[Todd Agulnick]

This has been fixed in Foxmarks 2.1.0.12, released 7/7/2008. Mike Perry, thanks for your help in diagnosing the problem.