Firefox leaks when the Google Toolbar for Firefox 3 is installed

RESOLVED INVALID

Status

()

defect
P2
normal
RESOLVED INVALID
11 years ago
a month ago

People

(Reporter: cbook, Assigned: peterv)

Tracking

({memory-leak})

1.9.0 Branch
x86
Windows XP
Points:
---
Bug Flags:
blocking1.9.1 -
wanted1.9.1 +
blocking1.9.0.1 -
wanted1.9.0.x +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

11 years ago
Posted file leak lauge log
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0

Steps to reproduce:
-> Install the Firefox 3 Build and a new Profile
-> Install the Google Toolbar from http://www.google.com/tools/firefox/toolbar/FT3/intl/en/
-> Use this Toolbar for a while, add a button to the Toolbar (thats a google toolbar feature),etc..
-> Close Firefox

When using Leak Gauge i get as report (see also the attachment):

Summary:
Leaked 19 out of 23 DOM Windows
Leaked 45 out of 64 documents
Leaked 10 out of 10 docshells
Leaked content nodes in 52 out of 71 documents
Flags: blocking1.9.1?
Flags: blocking1.9.0.1?
Whow, this looks really bad. And this is a popular extension too.
Flags: wanted1.9.0.x+
Priority: -- → P1
Flags: blocking1.9.1? → blocking1.9.1+
Flags: blocking1.9.0.1? → blocking1.9.0.1-
Who's gonna fix this, Jonas?
Peter, you've been looking at leaks still. Would you have the cycles to look at this one?
Assigning to peterv.  Peter, if you can't do this, can you please suggest someone else?
Assignee: nobody → peterv
(Assignee)

Comment 5

11 years ago
Tomcat, can you retest and update whether it still leaks windows? I tried reproducing and I saw leaks but no window leaks.
(Assignee)

Comment 6

11 years ago
Not a beta 1 blocker, Toolbar not compatible with beta 1.
Priority: P1 → P2
(Reporter)

Comment 7

11 years ago
hi peter, here is a new leak log with googletoobar and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.3pre) Gecko/2008092317
Minefield/3.0.3pre
Peter, have you had another chance to take a look at this leak?
This should most likely move to DOM.
Component: General → DOM
QA Contact: general → general
Given that this doesn't leak windows, documents, or docshells any more, we won't hold the release for this bug.
Flags: wanted1.9.1+
Flags: blocking1.9.1-
Flags: blocking1.9.1+

Comment 11

10 years ago
On updating to Firefox 3.5.x, i updated the google toolbar. Since, whenever i open the browser, the CPU usages hits the roof - 100% and the browser is stuck.
Alt+Ctrl+Delete shows Firefox 'not responding' status. The only option is to reopen Ff in safe mode, with all the Add-Ons disabled. Once the browser is opened and working successfully, you can enable all other add-ons except Google Toolbar.
This is a Window XP machine.

Comment 12

6 years ago
"Google Toolbar for Firefox has been discontinued

For details, see the announcement. There will be no further updates or security fixes to Google Toolbar for Firefox. For this reason we strongly recommend discontinuing the use of the toolbar."

https://www.google.com/intl/en/toolbar/ff/
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → INVALID
Discontinuing the firefox google toolbar was one of the worst things you have done. Can someone get to work updating it please. The IE version can stay dead as it was horrible but I would really like to get back the firefox version. If it comes back, I'll drop Google Chrome for sure.
The Google toolbar was a Google product.  We had no control over the decision to discontinue it :-(
OK. Then can you beg them to bring it back. Why is it that google is over and over discontinuing products that people are liking and using a lot and saying noone uses them and killing good products?
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.