440400 - Add pref to change number of rows shown at one time in locationbar autocomplete popup

Status: RESOLVED WONTFIX

(Firefox :: Address Bar, enhancement, P5)

Description

[nightstalkerz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1a1pre) Gecko/2008061803 Minefield/3.1a1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1a1pre) Gecko/2008061803 Minefield/3.1a1pre

Currently Firefox 3 only shows 6 results when searching from the location bar. This may not be enough if some of us have larger monitors so it would be nice to have a value in the about:config which lets the user change it.

Reproducible: Always

Steps to Reproduce:
1. Type something in the locationbar
2.
3.
Actual Results:  
Results returned are 6 rows before having to scroll.

Expected Results:  
Results returned are defaulted to 6 rows unless the user changes it.

The addon above contains code to do this and shouldn't take very long to intergrate.

Comment 1

[Dave Garrett]

browser.urlbar.maxRichResults

Comment 2

[nightstalkerz]

That changes the number of results which are returned. The thing I'm talking about is the autopopup when the user searches. It cannot be changed through the about:config.

Comment 3

[Dave Garrett]

Ah, the size of the popup and not the number of results in it.

Valid request.  I agree, this shouldn't be hardcoded.

See bug 406257 and bug 389584.

Comment 4

[RNicoletto]

A valid workaround is Locationbar Limit ==> https://addons.mozilla.org/en-US/firefox/addon/7674

However I would prefer an user_pref in about:config instead of using an extension.

Comment 6

[Alan Thomas]

Attachment: patch to add pref browser.urlbar.dropdownSize

Here is a patch which seems to work. It reads from the pref "browser.urlbar.dropdownSize", which is by default 6 (the current, hard-coded setting). The patch also fixes some busted indentation.

I'm not sure if the implementation is quite right - it does require a browser restart for any change to take effect.

Who can review for this component?

Comment 7

[Alan Thomas]

Attachment: patch

Un-bitrotting.

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 504216 [details] [diff] [review]
patch

>           if (searchBar && searchBar.textbox == this.mInput) {
>-            // Handle search bar popup clicks
>-            var search = controller.getValueAt(this.selectedIndex);
>+          // Handle search bar popup clicks
>+          var search = controller.getValueAt(this.selectedIndex);

hm?

Comment 9

[Alan Thomas]

Attachment: patch

Sorry about that.

Comment 10

[Dão Gottwald [:dao]]

Comment on attachment 504233 [details] [diff] [review]
patch

There's maxrows="6" in browser.xul which this patch seems to make obsolete.

>@@ -957,16 +958,30 @@
>                           .getService(Components.interfaces.nsIPrefBranch);
>               this._maxResults = prefService.getIntPref("browser.urlbar.maxRichResults");
>             }
>             return this._maxResults;
>           ]]>
>         </getter>
>       </property>
> 
>+      <property name="maxRows">
>+        <getter>
>+          <![CDATA[
>+            if (!this._maxRows) {
>+              var prefService =
>+                Components.classes["@mozilla.org/preferences-service;1"]
>+                          .getService(Components.interfaces.nsIPrefBranch);
>+              this._maxResults = prefService.getIntPref("browser.urlbar.dropdownSize");

This should be using Services.prefs.

Comment 11

[monperrus]

I confirm that https://addons.mozilla.org/en-US/firefox/addon/locationbar-limit/ is a workaround. 

It gives two options
> Results searched: N
> Rows visible: M

I don't understand the meaning of the first one "Results searched".

Comment 12

[Marco Bonardo [:mak]]

There's no plan to implement this, anyway the current panel iirc just grows with maxRichResults.