440583 - We should wrap long search strings when we return results

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

URL: https://sumo-reskin.authstage.mozilla.com/tiki-searchresults.php?locale=en-US&q=ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789345&sa=

I entered a 255-character long string and performed a Knowledge Base search; the resulting UI printed the raw string without wrapping, thus creating horizontal scrollbars.

See screenshot; notice also that the search parameter runs into the page-results numbers...

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Comment 2

[Brian Krausz]

There's really no way to easily wrap that, if there were spaces in it it would auto-wrap.

Will fix spacing issue though...that is legit.

Comment 3

[Brian Krausz]

Spacing issue: only happens when searching for strings > ~65chars with no spaces

length issue is a general Sumo bug[1], reassigning.

I'm going to fix the search results layout now anyway so it looks better with the theme.

[1] http://support.mozilla.com/tiki-searchresults.php?locale=en-US&q=ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789345&sa

Comment 4

[Paul Craciunoiu [:paulc]]

It works for IE apparently, with:
word-wrap: break-word;
But this is not supported in Firefox, prior to 3.1, see:
https://developer.mozilla.org/web-tech/2008/08/20/word-wrap-break-word/

Here's a way to make it work in Firefox that I think is too complicated:
http://blog.stchur.com/2007/03/01/word-wrap-for-mozilla-take-2/

I've added a simple smarty truncate at 60 characters. I think this should be satisfying, as most people don't search >60 char words and *not showing* that is not a problem.

r22936 / r22937

Comment 5

[Paul Craciunoiu [:paulc]]

Woops, on second thought... The search *could* be longer than 60, but the last word shouldn't be. Sorry about that. I'll redo with the longest word in a sec :)

Comment 6

[Paul Craciunoiu [:paulc]]

There we go, r22939 / r22940.
This turns long words into ending with '...' and keeps the other words as well. See:
https://support-stage.mozilla.org/tiki-searchresults.php?locale=en-US&q=MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM+firefox+search&sa

Comment 7

[Paul Craciunoiu [:paulc]]

Actually, I'd rather wait on Eric's solution before choosing to go this way. Sorry about this. See bug 450342. I've undone the changes.

Comment 8

[Paul Craciunoiu [:paulc]]

Eric: If you get to the text wrapping bugs, can you take care of this bug too?

Comment 9

[E. Cooper [:ecooper]]

Are we fixing this if we're using tiki-newsearch.php?

Comment 10

[Paul Craciunoiu [:paulc]]

Well, our problems with wrapping are not just about this bug. I remember you had a similar bug that may fix all these wrapping stuff. You want some help with that?

Anyway
http://support-stage.mozilla.org/tiki-newsearch.php?locale=&q=ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789345&where=all&sa=&l=ar&lastmodif=0&type=0&author=
looks bad too.

Comment 11

[E. Cooper [:ecooper]]

Attachment: v1

Simple patch.

Paul if you can't look at this before tomorrow night, reassign to Laura.

Comment 12

[Paul Craciunoiu [:paulc]]

Comment on attachment 373977 [details] [diff] [review]
v1

Looks good. I like it, it's simple. We should see if this fixes the other bugs about long strings (there were others, I think?)

Comment 13

[E. Cooper [:ecooper]]

This is in r24917/r24918 with a small modification to ignore short strings.

For verifying, plug in some long strings with no spaces, and also make sure rendering problems don't occur in normal searches (i.e. simple searches, quoted searches, multibyte language searches, etc.).

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

http://support-stage.mozilla.org/tiki-newsearch.php?q=ABCDE%E2%80%8BFGHIJ%E2%80%8BKLMNO%E2%80%8BPQRST%E2%80%8BUVWXY%E2%80%8BZ0123%E2%80%8B45678%E2%80%8B9ABCD%E2%80%8BEFGHI%E2%80%8BJKLMN%E2%80%8BOPQRS%E2%80%8BTUVWX%E2%80%8B+YZ012%E2%80%8B34567%E2%80%8B89ABC%E2%80%8BDEFGH%E2%80%8BIJKLM%E2%80%8BNOPQR%E2%80%8BSTUVW%E2%80%8BXYZ01%E2%80%8B23456%E2%80%8B789AB%E2%80%8BCDEFG%E2%80%8BHIJKL%E2%80%8B+MNOPQ%E2%80%8BRSTUV%E2%80%8BWXYZ0%E2%80%8B12345%E2%80%8B6789A%E2%80%8BBCDEF%E2%80%8BGHIJK%E2%80%8BLMNOP%E2%80%8BQRSTU%E2%80%8BVWXYZ%E2%80%8B01234%E2%80%8B56789%E2%80%8B+ABCDE%E2%80%8BFGHIJ%E2%80%8BKLMNO%E2%80%8BPQRST%E2%80%8BUVWXY%E2%80%8BZ0123%E2%80%8B45678%E2%80%8B9ABCD%E2%80%8BEFGHI%E2%80%8BJKLMN%E2%80%8BOPQRS%E2%80%8BTUVWX%E2%80%8B+YZ012%E2%80%8B34567%E2%80%8B89345%E2%80%8B&sa=

and

http://support-stage.mozilla.org/tiki-newsearch.php?locale=&q=ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789345&where=all&sa=&l=ar&lastmodif=0&type=0&author

as testcases.