440629 - Find toolbar should display the number of matches

Status: RESOLVED DUPLICATE of bug 257061

(Toolkit :: Find Toolbar, enhancement)

Description

[Michael Ventnor]

Attachment: Patch

I searched and couldn't find a dupe, so if there is one feel free to abuse me over the internet.

It would be nice if the findbar could display the number of times the term appears on a page, it makes it slightly easier to know if the page has what you really want.

Comment 1

[Kai Liu]

There's an extension that does this, if you wanted to compare implementations:
https://addons.mozilla.org/firefox/6738

Comment 2

[(no longer active)]

This is a dupe of bug 257061.

I had written a patch for this bug about a year ago (attachment 294747 [details] [diff] [review]) which was r-'ed by mano (see bug 257061 comment 6) because my implementation was in the XBL binding, and mano correctly stated that it could be useful to all consumers of nsIWebBrowserFind.

Implementation-wise, my patch handles the case of links-only searches, and makes sure that invisible elements are not counted in (so that the number of matches displayed is in sync with what actually gets found if the user presses the Next button repeatedly.)  One things it doesn't handle and your patch does is the plural forms (see bug 257061 comment 25) but I kind of left it off to when the nsIWebBrowserFind implementation is completed.

The bug I filed for the nsIWebBrowserFind implementation is bug 389159.  It also has a patch (attachment 284753 [details] [diff] [review]) which was written a long time ago and never got reviewed.

Oh, and BTW, the Find In Numbers extension <https://addons.mozilla.org/firefox/6738> is basically the same code in attachment 294747 [details] [diff] [review], albeit modified in order to work with both 1.8 and 1.9 as an extension.