44094 - XML parsing error message shows column off by 1

Status: VERIFIED FIXED

(Core :: XML, defect, P3)

Description

[demian.godon]

Load wf_constraint_tag_empty.xml (from mozilla test page)
Result --> XML parsing error message is displayed showing the offending line 
number and column.  In this case it claims the column is 27 when it looks to me 
like it should be 28.  IE 5 reports the error as being on position 28.

Comment 1

[Chris Petersen]

I loaded the same xml file and got the same results. The reason for this is we   
assign the first column item a value of "0" instead "1" like apparently IE does.

Comment 2

[Nisheeth Ranjan]

This is a trivial fix and will prove to be an annoying problem for XML page authors.

Nominating for nsbeta3

Comment 3

[Nisheeth Ranjan]

Might pull this one in if I fix my other beta3+ bugs.  But, right now, marking 
beta3- and adding relnote keyword.

This bug has been marked nsbeta3- because the original netscape engineer working 
on this is over-burdened. If you feel this is an error, that you or another
known resource will be working on this bug,or if it blocks your work in some way 
-- please attach your concern to the bug for reconsideration, but do not clear 
the nsbeta3- nomination.

Comment 4

[ekrock's old account (dead)]

Nom. nsbeta1. Let's change this to be consistent with the behavior of IE.
Neither index value is "more correct" than the other, and cross-browser
off-by-one inconsistencies are just plan annoying and help no one, so we'll
remove one more point of confusion from developers' lives if we work the same as IE.

Comment 5

[Nisheeth Ranjan]

Setting target milestone to mozilla0.8.

Comment 6

[Dan Rosen]

nisheeth: if you're busy, i'll take this (just let me know what you had in mind
as a fix).

Comment 7

[Nisheeth Ranjan]

I'm really sorry for not getting this onto the 0.8 train.  This will be the 
first thing that lands for 0.9.  I won't even attempt to make an excuse for this 
one!  This is trivial to fix.

Comment 8

[Nisheeth Ranjan]

Attachment: Patch for fix

Comment 9

[harishd]

patch (id=24919) looks good. r=harishd

Comment 10

[Nisheeth Ranjan]

Attachment: XML file that produces error message (testcase)

Comment 11

[vidur (gone)]

sr=vidur. Not a 0.8 stopper, I'm sure.

Comment 12

[Christopher Blizzard (:blizzard)]

Yeah, wait for after we re-open for 0.8.

Comment 13

[Nisheeth Ranjan]

Fix checked in.

Comment 14

[Chris Petersen]

Marking verified fixed in the Feb 26th build.