Closed Bug 441470 Opened 16 years ago Closed 16 years ago

Bookmark lost when dragged within folder shortcuts menus

Categories

(Firefox :: Bookmarks & History, defect, P2)

defect

Tracking

()

VERIFIED FIXED
Firefox 3.1b3

People

(Reporter: hippofood, Assigned: mak)

References

Details

(Keywords: dataloss, verified1.9.1)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0

Smart bookmarks in Unsorted Bookmarks will be lost if they are dragged to a different location in the drop-down list.

Reproducible: Always

Steps to Reproduce:
1. Create a new bookmark in the bookmark toolbar with Location: place:folder=UNFILED_BOOKMARKS
2. Click the dropdown menu you made and drag one of the unsorted bookmarks
Actual Results:  
Bookmark disappears, and doesn't appear anywhere in Organize Bookmarks.

Expected Results:  
Bookmark moves to the location it was dragged to in the drop-down list

A lit up yellow star will still appear if you manually go to the URL of the lost bookmark.
Component: Bookmarks → Places
Keywords: dataloss
QA Contact: bookmarks → places
Summary: Bookmark lost when dragged within drop-down menu (dataloss, smart bookmarks) → Bookmark lost when dragged within drop-down menu (smart bookmarks)
Mardeg confirmed in IRC.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Depends on: 418671
still valid, dataloss confirmed

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre) Gecko/20080920033605 Minefield/3.1b1pre
Target Milestone: --- → Firefox 3.1
asking blocking for dataloss
Flags: blocking-firefox3.1?
Flags: blocking-firefox3.1? → blocking-firefox3.1+
Priority: -- → P2
Version: unspecified → Trunk
taking for now
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attached patch patchSplinter Review
we should drop to the concrete id, obviously.
Attachment #351246 - Flags: review?(dietrich)
Whiteboard: [has patch][needs review dietrich]
Attachment #351246 - Flags: review?(dietrich) → review+
Whiteboard: [has patch][needs review dietrich] → [has patch][has review]
OS: Windows XP → All
Hardware: PC → All
OS: All → Windows XP
Hardware: All → PC
Summary: Bookmark lost when dragged within drop-down menu (smart bookmarks) → Bookmark lost when dragged within folder shortcuts menus
pushed to trunk:
http://hg.mozilla.org/mozilla-central/rev/6a041ed8bf9f
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
pushed to 1.9.1 branch:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/230f4b180b35
Keywords: fixed1.9.1
Whiteboard: [has patch][has review]
Target Milestone: Firefox 3.1 → Firefox 3.1b3
As Marco pointed out on IRC we don't have d&d tests yet. Means, we should add
this d&d behavior as a testcase on Litmus.
Severity: normal → critical
Flags: in-litmus?
OS: Windows XP → All
Hardware: x86 → All
verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090127 Shiretoko/3.1b3pre
Status: RESOLVED → VERIFIED
I've given ddahl a list of test cases to make autoamted cases for... this wuld be one of them


-for in-litmus.
Flags: in-testsuite?
Flags: in-litmus?
Flags: in-litmus-
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
removing ancient in-testsuite requests
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: