441519 - nsOuterDocAccessible chrome tests

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

Test that we properly create the INTERNAL_FRAME parent for HTML docs.

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Mochitest

Test for role, state not containing STATE_FOCUSABLE, empty name (see bug 428954), and no actions (bug 440770).

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 326465 [details] [diff] [review]
Mochitest


>+          // see bug 440770, no actions wanted on outer doc
>+          is(outerDocAcc.numActions, 0,
>+             "Wrong number of actions for internal frame!");

possible it makes sense to test all action related methods, it's up to you.

Comment 3

[Marco Zehe (:MarcoZ)]

Attachment: Patch2

Added tests for the action-related methods, testing specifically for a return vale of NS_ERROR_INVALID_ARG in the exception handler. If no exception should be thrown, we catch that by the do_throw call. Re-requesting review for this.

Comment 4

[alexander :surkov (:asurkov)]

Comment on attachment 326650 [details] [diff] [review]
Patch2

r=me, thanks

Comment 5

[Marco Zehe (:MarcoZ)]

Pushed to mozilla-central in changeset:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/a78c4eeaf51c

Comment 6

[Marco Zehe (:MarcoZ)]

Checking in accessible/tests/mochitest/Makefile.in;
/cvsroot/mozilla/accessible/tests/mochitest/Makefile.in,v  <--  Makefile.in
new revision: 1.17; previous revision: 1.16
done
RCS file: /cvsroot/mozilla/accessible/tests/mochitest/test_nsOuterDocAccessible.html,v
done
Checking in accessible/tests/mochitest/test_nsOuterDocAccessible.html;
/cvsroot/mozilla/accessible/tests/mochitest/test_nsOuterDocAccessible.html,v  <--  test_nsOuterDocAccessible.html
initial revision: 1.1
done

Test for fix for bug 440770 included here.