Closed Bug 441519 Opened 13 years ago Closed 13 years ago

nsOuterDocAccessible chrome tests

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.1a1

People

(Reporter: MarcoZ, Assigned: MarcoZ)

References

(Blocks 1 open bug)

Details

(Keywords: access, fixed1.9.0.2)

Attachments

(1 file, 1 obsolete file)

Test that we properly create the INTERNAL_FRAME parent for HTML docs.
Attached patch Mochitest (obsolete) — Splinter Review
Test for role, state not containing STATE_FOCUSABLE, empty name (see bug 428954), and no actions (bug 440770).
Attachment #326465 - Flags: review?(surkov.alexander)
Comment on attachment 326465 [details] [diff] [review]
Mochitest


>+          // see bug 440770, no actions wanted on outer doc
>+          is(outerDocAcc.numActions, 0,
>+             "Wrong number of actions for internal frame!");

possible it makes sense to test all action related methods, it's up to you.
Attachment #326465 - Flags: review?(surkov.alexander) → review+
Attached patch Patch2Splinter Review
Added tests for the action-related methods, testing specifically for a return vale of NS_ERROR_INVALID_ARG in the exception handler. If no exception should be thrown, we catch that by the do_throw call. Re-requesting review for this.
Attachment #326465 - Attachment is obsolete: true
Attachment #326650 - Flags: review?(surkov.alexander)
Comment on attachment 326650 [details] [diff] [review]
Patch2

r=me, thanks
Attachment #326650 - Flags: review?(surkov.alexander) → review+
Pushed to mozilla-central in changeset:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/a78c4eeaf51c
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9.1 → mozilla1.9.1a1
Checking in accessible/tests/mochitest/Makefile.in;
/cvsroot/mozilla/accessible/tests/mochitest/Makefile.in,v  <--  Makefile.in
new revision: 1.17; previous revision: 1.16
done
RCS file: /cvsroot/mozilla/accessible/tests/mochitest/test_nsOuterDocAccessible.html,v
done
Checking in accessible/tests/mochitest/test_nsOuterDocAccessible.html;
/cvsroot/mozilla/accessible/tests/mochitest/test_nsOuterDocAccessible.html,v  <--  test_nsOuterDocAccessible.html
initial revision: 1.1
done

Test for fix for bug 440770 included here.
Keywords: fixed1.9.0.2
You need to log in before you can comment on or make changes to this bug.