441732 - Anti-phishing "blocked" page needs its own site icon

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We need to make it not use the same icon as the error pages, as that's confusing, and we don't want to muddy the waters at all.

We should just be able to use the existing popup_blocked_icon.tiff for the site icon (and that will match the "blocked" imagery we have from Jon to use on the page itself).

If we land anti-phishing before a1, this also should land before a1.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This needs to block b2.

Comment 2

[Stuart Morgan]

Attachment: fix

Is there a straightforward way to tell if we are in overlay mode? Nothing jumped out at me, so this seemed like the easiest approach. (If there is one, this is probably overkill.)

Comment 3

[Sean Murphy]

Comment on attachment 363442 [details] [diff] [review]
fix

Looks great to me.  r=murph.

Comment 4

[Mike Pinkerton (not reading bugmail)]

+  eRequestSucceeded,
+  eRequestFailed,
+  eRequestBlocked

is it worth adding a comment to be more specific about what each of these means?

sr=pink

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 363442 [details] [diff] [review]
fix

sr=pink

Comment 6

[Stuart Morgan]

Landed on CVS trunk.