Add missing error checks in search views

RESOLVED FIXED in mozilla1.9.1a1

Status

RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: rkent, Assigned: rkent)

Tracking

Trunk
mozilla1.9.1a1
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
A few weeks ago, my development system got into a state where it was hanging. I managed to stop the hang by adding some missing error checks. The hang also went away when some unknown patch was added to trunk, but I figured the error checks are worth adding. I'll submit them for review.
(Assignee)

Comment 1

11 years ago
Created attachment 326845 [details] [diff] [review]
Added some checks

These missing checks and incorrect returns may have caused my system to hang at some point during development.
Attachment #326845 - Flags: superreview?(neil)
Attachment #326845 - Flags: review?(neil)

Updated

11 years ago
Attachment #326845 - Flags: superreview?(neil)
Attachment #326845 - Flags: superreview+
Attachment #326845 - Flags: review?(neil)
Attachment #326845 - Flags: review+
(Assignee)

Updated

11 years ago
Keywords: checkin-needed
Checking in mailnews/base/src/nsMsgAccountManager.cpp;
/cvsroot/mozilla/mailnews/base/src/nsMsgAccountManager.cpp,v  <--  nsMsgAccountManager.cpp
new revision: 1.339; previous revision: 1.338
done
Checking in mailnews/base/src/nsMsgDBView.cpp;
/cvsroot/mozilla/mailnews/base/src/nsMsgDBView.cpp,v  <--  nsMsgDBView.cpp
new revision: 1.315; previous revision: 1.314
done
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.1a1
(Assignee)

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.