gAppData null check not required in nsXREDirProvider::GetUserDataDirectoryHome

RESOLVED FIXED in mozilla1.9.1a2

Status

()

RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla1.9.1a2
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Created attachment 326859 [details] [diff] [review]
Possible fix

./run-mozilla.sh ./TestGtkEmbed about:

...............
*** registering nsLoginManager.js: [ LoginManager ]
*** registering nsBlocklistService.js: [ Blocklist Service ]
*** Registering done.
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file mozilla/toolkit/xre/nsXREDirProvider.cpp, line 1079
...............

Warning appears because gAppData not defined and 
GetUserDataDirectoryHome return always NS_ERROR:
http://mxr.mozilla.org/seamonkey/source/toolkit/xre/nsXREDirProvider.cpp#985
Attachment #326859 - Flags: review?(benjamin)
(Assignee)

Comment 1

11 years ago
I'm not sure, maybe Embedding: GRE Core is more better component for this bug?

Updated

10 years ago
Attachment #326859 - Flags: review?(benjamin) → review+
Assignee: nobody → romaxa
Keywords: checkin-needed

Updated

10 years ago
Component: XRE Startup → Startup and Profile System
QA Contact: xre.startup → startup
<http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1217484420.1217485284.24505.gz>
{{
Linux nye Depend bloat on 2008/07/30 23:07:00

WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /home/andrew/tbox/SeaMonkey-Debug/Linux_2.6.22.14-72.fc6_Depend/src/mozilla/toolkit/xre/nsXREDirProvider.cpp, line 1134
}}

***

checkin-needed !
Keywords: assertion
Landed: http://hg.mozilla.org/index.cgi/mozilla-central/rev/1b2644a57966
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a2
(In reply to comment #2)
> .../toolkit/xre/nsXREDirProvider.cpp, line 1134

Different bug ... moved to bug 450898.
Keywords: assertion
You need to log in before you can comment on or make changes to this bug.