Closed
Bug 44199
Opened 26 years ago
Closed 26 years ago
background image is moving when position is definied with px,pt,cm,em etc.
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Tracking
()
VERIFIED
FIXED
M18
People
(Reporter: development, Assigned: attinasi)
References
()
Details
(Keywords: css1, Whiteboard: [nsbeta2-] [nsbeta3+])
Attachments
(4 files)
This is a very funny one. Some time ago definied backgrounds disappear from a
page i made. The URL consist of 3 frames, 2 of them use css to place an image.
I´ve used following code (top.html):
body { background: #FFFFFF url(gfx/engineers.gif) no-repeat fixed 60px 0px}
when page is loaded there is no image visible, but when you resize the page and
make it smaller(horiz.) the image moves in from right to left. you must do a
slow resize.
i´ve played around a little bit and found following out:
background image is moving when position is definied with px,pt,cm,em etc.
when you use e.g. :
body { background: #FFFFFF url(gfx/engineers.gif) no-repeat fixed top left}
background is visible and does not move (top right or bottom left also works)!!
another interesting fact is when i use 1pt 1pt and i resize the page, the image
moves slower than with px etc.
this occures horizontaly and verticaly.
Sorry for my bad english.
Testet with BuildID 2000062820 on WinNT.
| Reporter | ||
Comment 2•26 years ago
|
||
| Reporter | ||
Comment 3•26 years ago
|
||
| Reporter | ||
Comment 4•26 years ago
|
||
| Assignee | ||
Comment 5•26 years ago
|
||
Horwath, no need to apologize for your English, thanks for reporting this bug!
The problem appears to be with any background-position unit other than % - we
are simply not supporting it correctly (the top,center,bottom,right,left,etc.
seem to work too).
I'll look into the code to see what the problem is. Since the Style Context data
looks correct I am guessing it is in the CSSRendering where the background is
drawn.
Assignee: pierre → attinasi
| Assignee | ||
Updated•26 years ago
|
Status: NEW → ASSIGNED
| Assignee | ||
Comment 7•26 years ago
|
||
The problem is that the unit is getting lost on the attachment value... In The
BodyFixupRule::MapStyleInto method, where the background image is propogated up
to the canvas, the backgroundFlags are not correctly propagated, and the unit
(length or percent) is in those flags. It is effectively being treated like a
percent value now, except that it is first getting translated to a twip value...
I'll attach a patch shortly.
| Assignee | ||
Comment 8•26 years ago
|
||
| Assignee | ||
Comment 10•26 years ago
|
||
On what grounds was this nominated for nsbeta2? It does nothing to stabilize or
improve performance, it merely fixes a minor cosmetic bug. I urge beta3
nomination instead.
Comment 11•26 years ago
|
||
Putting on [nsbeta2-] radar. Not critical to beta2. Adding "nsbeta3" keyword
for consideration of a fix for that milestone.
Keywords: nsbeta3
Whiteboard: [nsbeta2-]
Updated•26 years ago
|
Keywords: correctness
Comment 12•26 years ago
|
||
With Build ID 2000072520 I don't see the Engeneers logo neither
the background Image. This is far from fixed.
| Assignee | ||
Comment 13•26 years ago
|
||
The fix has not been checked in yet - we have to wait for the branch to take
place before general beta3 checkins can commence. Please check back when the bug
is marked FIXED - should be pretty soon since we are branching today.
Comment 14•26 years ago
|
||
As per meeting with ChrisD yesterday, taking QA.
QA Contact: ckritzer → py8ieh=bugzilla
| Assignee | ||
Comment 15•26 years ago
|
||
Approving for beta3: have fix that is simple and low risk.
Whiteboard: [nsbeta2-] → [nsbeta2-] [nsbeta3+]
| Assignee | ||
Comment 16•26 years ago
|
||
Can somebody review the patch for me please
(http://bugzilla.mozilla.org/showattachment.cgi?attach_id=11277)?
I'd like to check it in today.
r=dbaron
| Assignee | ||
Comment 18•26 years ago
|
||
Fix checked in - Thanks for the review David
(nsHTMLBodyElement.cpp)
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Comment 19•26 years ago
|
||
VERIFIED FIXED with Windows 2000 and Linux Commercial builds 20000090808.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•