441992 - caldav and ics calendar aren't disabled after canceling the login dialog

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[Andreas Treumann]

STEPS TO REPRODUCE:
===================

- use caldav server http://rscds.zathras.lss.wisc.edu/caldav.php/mozilla/home/
- don't save user/password 
- restart thunderbird/lightning
- click 'cancel' in the login dialog

RESULT:
=======

- the caldav calendar is not switched off

EXPECTED RESULT:
================

- the caldav calendar should be switched off

REPRODUCIBLE:
=============

- always

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Wow, this one is really annoying. I want this for 1.0

Comment 2

[Simon Vaillancourt]

Note that the patch for bug 435854 should make this a lot less annoying: Instead of re-prompting immediately for the password, it will re-prompt at the next refresh or at the next manual reload which I think is an acceptable behavior, at least it gives the user the chance to go and disable the calendars he doesn't want.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Taking this off the needed-beta list due to the previous comment and lack of time.

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

This takes care, not only for caldav but also for ics.

Comment 5

[Matthew Mecca [:mmecca]]

Comment on attachment 549083 [details] [diff] [review]
Fix - v1

Looks good. r=mmecca

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/2d09dbd96fcd>
-> FIXED

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Backported to comm-aurora <http://hg.mozilla.org/releases/comm-aurora/rev/8e731eb1d074>

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

Backported to comm-beta <http://hg.mozilla.org/releases/comm-beta/rev/96f43866b0e2>