Closed Bug 442003 Opened 12 years ago Closed 12 years ago

Create a binding to easily add notification bars to emails

Categories

(Calendar :: Lightning Only, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

References

Details

Attachments

(1 file)

Attached patch Consolidate - v1Splinter Review
To make it easier to create further bars similar to the imip bar, we should consolidate this bar into a binding.

For example, to create a bar as proposed in the screenshot in bug 403222, the following overlay could be used (obviously with entities rather than hardcoded strings)

<?xml-stylesheet href="chrome://lightning/content/lightning-widgets.css" type="text/css"?>
<overlay xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">

  <vbox id="messagepanebox">
    <lightning-notification-bar id="eventfilter-bar"
                                insertBefore="msgHeaderView"
                                label="This event contains event info.
                                       Would you like to add it to a calendar?">
      <button id="eventfilter-yes" label="Yes"/>
      <button id="eventfilter-no" label="No"/>
    </lightning-notification-bar>
  </vbox>
</overlay>
Attachment #326884 - Flags: review?(Berend.Cornelius)
Comment on attachment 326884 [details] [diff] [review]
Consolidate - v1

patch looks good. At first I thought some more functionality should be located within the binding instead of in imipbar.js, but it looks like all relevant actions come from the three buttons that are defined outside the binding (for good reason).
r=berend
Attachment #326884 - Flags: review?(Berend.Cornelius) → review+
Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.9
Checked via mxr.mozilla.org -> VERIFIED
Status: RESOLVED → VERIFIED
Blocks: 886124
You need to log in before you can comment on or make changes to this bug.