442003 - Create a binding to easily add notification bars to emails

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Consolidate - v1

To make it easier to create further bars similar to the imip bar, we should consolidate this bar into a binding.

For example, to create a bar as proposed in the screenshot in bug 403222, the following overlay could be used (obviously with entities rather than hardcoded strings)

<?xml-stylesheet href="chrome://lightning/content/lightning-widgets.css" type="text/css"?>
<overlay xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">

  <vbox id="messagepanebox">
    <lightning-notification-bar id="eventfilter-bar"
                                insertBefore="msgHeaderView"
                                label="This event contains event info.
                                       Would you like to add it to a calendar?">
      <button id="eventfilter-yes" label="Yes"/>
      <button id="eventfilter-no" label="No"/>
    </lightning-notification-bar>
  </vbox>
</overlay>

Comment 1

[Berend Cornelius]

Comment on attachment 326884 [details] [diff] [review]
Consolidate - v1

patch looks good. At first I thought some more functionality should be located within the binding instead of in imipbar.js, but it looks like all relevant actions come from the three buttons that are defined outside the binding (for good reason).
r=berend

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 3

[Andreas Treumann]

Checked via mxr.mozilla.org -> VERIFIED