Closed
Bug 442009
Opened 16 years ago
Closed 16 years ago
libxul-embedding.pc and libxul-embedding-unstable.pc files should require NSPR
Categories
(Toolkit Graveyard :: XULRunner, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: stransky, Unassigned)
Details
Attachments
(1 file)
1.06 KB,
patch
|
benjamin
:
review-
|
Details | Diff | Splinter Review |
libxul-embedding and libxul-embedding-unstable *.pc files should require NSPR. Embedded applications don't build w/o it.
Comment 1•16 years ago
|
||
Comment on attachment 326889 [details] [diff] [review] proposed patch to those files Linkin NSPR is not a requirement for embedded applications... obviously the headers are required for building, but NSPR link flags should not be implied.
Attachment #326889 -
Flags: review-
Reporter | ||
Comment 2•16 years ago
|
||
Honestly I know about only one application what builds as embedded and it's liferea in Fedora. It's linked with NSS/NSPR. If you think the embedded apps should not link with nspr (actually it makes sense) we can close this report and I'll fix the liferea package.
Comment 3•16 years ago
|
||
It's not that they "shouldn't", it's that they "might not want to". I think it's perfectly fine for lifarea to link against NSPR/NSS especially when they are system libraries... just they should pull in NSPR/NSS explicitly instead of depending on libxul-embedding.pc to do it. Make sense?
Reporter | ||
Comment 4•16 years ago
|
||
Yep, fair enough. closing as wontfix.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → WONTFIX
Assignee | ||
Updated•8 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•